You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michael Frankerl (JIRA)" <ji...@apache.org> on 2010/11/19 12:51:16 UTC

[jira] Created: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
--------------------------------------------------------------------------------------------------

                 Key: WICKET-3180
                 URL: https://issues.apache.org/jira/browse/WICKET-3180
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.4.13
            Reporter: Michael Frankerl


DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Michael Frankerl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Frankerl updated WICKET-3180:
-------------------------------------

    Attachment: AjaxIndicatorAwareDropDownChoice.java

> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>         Attachments: AjaxIndicatorAwareDropDownChoice.java
>
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Michael Frankerl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934406#action_12934406 ] 

Michael Frankerl commented on WICKET-3180:
------------------------------------------

The purpose is to use the same indication function, that indicates that the submit has started as in the mentioned ajax implementations. 
You are right, this is not a typical ajax request, but it is a script triggered submit. The DropDownChoice has its own ajaxlike behaviour and does not use an behaviour implementation for any reason.

> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>         Attachments: AjaxIndicatorAwareDropDownChoice.java
>
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Michael Frankerl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933796#action_12933796 ] 

Michael Frankerl edited comment on WICKET-3180 at 11/19/10 8:05 AM:
--------------------------------------------------------------------

I would like to see a fallbacking implementation in the above mentioned DropDownChoice#onComponentTag() method. See my example code.


  
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>         Attachments: AjaxIndicatorAwareDropDownChoice.java
>
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933781#action_12933781 ] 

Martin Grigorov commented on WICKET-3180:
-----------------------------------------

What do you mean ?

All you need to do is to create MyDropDownChoice that implements IAjaxIndicatorAware and then adding any Ajax behavior to your component will automatically do what you want.


> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3180.
-------------------------------------

       Resolution: Won't Fix
    Fix Version/s: 1.5-M4
                   1.4.14
         Assignee: Martin Grigorov

Still the purpose is not clear.
The indicator should be used in Ajax requests. In your code I don't see anything Ajax related. It seems you show the indicator just before complete page reload.


> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>         Attachments: AjaxIndicatorAwareDropDownChoice.java
>
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-3180:
-------------------------------------

    Fix Version/s:     (was: 1.5-M4)
                       (was: 1.4.14)

Removing fix versions on things that were marked as fixVersion = (1.4.14 || 1.5-M4), but also weren't fixed (marked "not a problem", "won't fix", etc) so that they don't show up in release notes when in reality they weren't part of the release.

> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>            Assignee: Martin Grigorov
>         Attachments: AjaxIndicatorAwareDropDownChoice.java
>
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3180) DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934407#action_12934407 ] 

Igor Vaynberg commented on WICKET-3180:
---------------------------------------

the choice is not ajax-like. it performs a regular submit, much like the form. i do not think something like this belongs in the core. browsers have a request indicator for regular requests which will be triggered by the dropdown choice.

> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3180
>                 URL: https://issues.apache.org/jira/browse/WICKET-3180
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Michael Frankerl
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>         Attachments: AjaxIndicatorAwareDropDownChoice.java
>
>
> DropDownChoice should use IAjaxIndicatorAware like AbstractDefaultAjaxBehavior.findIndicatorId()  in it's onComponentTag method, in order to work with the same indicatior mechanism.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.