[superset] branch arash.afghahi/sc-65239/alerts-reports-the-same-list-is-displayed updated (f7e21e4900 -> df8941b2bb)

[aa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aafghahi pushed a change to branch arash.afghahi/sc-65239/alerts-reports-the-same-list-is-displayed
in repository https://gitbox.apache.org/repos/asf/superset.git


 discard f7e21e4900 alert modal bug fix
     new df8941b2bb alert modal bug fix

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (f7e21e4900)
            \
             N -- N -- N   refs/heads/arash.afghahi/sc-65239/alerts-reports-the-same-list-is-displayed (df8941b2bb)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 superset-frontend/src/components/Select/AsyncSelect.tsx | 3 ---
 1 file changed, 3 deletions(-)

[superset] 01/01: alert modal bug fix

[aa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aafghahi pushed a commit to branch arash.afghahi/sc-65239/alerts-reports-the-same-list-is-displayed
in repository https://gitbox.apache.org/repos/asf/superset.git

commit df8941b2bbbff56313c9586e14205538df0e7e73
Author: AAfghahi <ar...@gmail.com>
AuthorDate: Wed Jan 11 12:55:13 2023 -0500

    alert modal bug fix
---
 superset-frontend/src/components/Select/AsyncSelect.tsx | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/superset-frontend/src/components/Select/AsyncSelect.tsx b/superset-frontend/src/components/Select/AsyncSelect.tsx
index 5cbd193c56..2db8dc0b74 100644
--- a/superset-frontend/src/components/Select/AsyncSelect.tsx
+++ b/superset-frontend/src/components/Select/AsyncSelect.tsx
@@ -203,7 +203,6 @@ const AsyncSelect = forwardRef(
       () => initialOptions.slice().sort(sortComparatorForNoSearch),
       [initialOptions, sortComparatorForNoSearch],
     );
-
     const [selectOptions, setSelectOptions] =
       useState<SelectOptionsType>(initialOptionsSorted);
 
@@ -218,7 +217,6 @@ const AsyncSelect = forwardRef(
         ? missingValues.concat(selectOptions)
         : selectOptions;
     }, [selectOptions, selectValue]);
-
     const handleOnSelect = (
       selectedItem: string | number | AntdLabeledValue | undefined,
     ) => {
@@ -442,7 +440,7 @@ const AsyncSelect = forwardRef(
       fetchedQueries.current.clear();
       setAllValuesLoaded(false);
       setSelectOptions(initialOptions);
-    }, [initialOptions]);
+    }, [initialOptions, options]);
 
     useEffect(() => {
       setSelectValue(value);