You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/07/30 23:47:06 UTC
Re: Review Request: Slave should shutdown properly on exit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6146/
-----------------------------------------------------------
(Updated July 30, 2012, 9:47 p.m.)
Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.
Changes
-------
changed title to properly reflect this review
Summary (updated)
-----------------
Slave should shutdown properly on exit
Description
-------
See summary
This addresses bug MESOS-244.
https://issues.apache.org/jira/browse/MESOS-244
Diffs
-----
src/exec/exec.cpp d60c28d
src/slave/process_based_isolation_module.cpp b54f91c
src/webui/webui.cpp 9453002
third_party/libprocess/include/stout/os.hpp 1186d24
Diff: https://reviews.apache.org/r/6146/diff/
Testing
-------
Need more specific tests.
But 'make check' succeeds.
Thanks,
Vinod Kone
Re: Review Request: Slave should shutdown properly on exit
Posted by Vinod Kone <vi...@gmail.com>.
> On July 30, 2012, 10:15 p.m., Jie Yu wrote:
> > third_party/libprocess/include/stout/os.hpp, line 112
> > <https://reviews.apache.org/r/6146/diff/4/?file=130805#file130805line112>
> >
> > check indent.
done
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6146/#review9612
-----------------------------------------------------------
On July 30, 2012, 9:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6146/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 9:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.
>
>
> Description
> -------
>
> See summary
>
>
> This addresses bug MESOS-244.
> https://issues.apache.org/jira/browse/MESOS-244
>
>
> Diffs
> -----
>
> src/exec/exec.cpp d60c28d
> src/slave/process_based_isolation_module.cpp b54f91c
> src/webui/webui.cpp 9453002
> third_party/libprocess/include/stout/os.hpp 1186d24
>
> Diff: https://reviews.apache.org/r/6146/diff/
>
>
> Testing
> -------
>
> Need more specific tests.
>
> But 'make check' succeeds.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Slave should shutdown properly on exit
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6146/#review9612
-----------------------------------------------------------
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/6146/#comment20503>
check indent.
- Jie Yu
On July 30, 2012, 9:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6146/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 9:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.
>
>
> Description
> -------
>
> See summary
>
>
> This addresses bug MESOS-244.
> https://issues.apache.org/jira/browse/MESOS-244
>
>
> Diffs
> -----
>
> src/exec/exec.cpp d60c28d
> src/slave/process_based_isolation_module.cpp b54f91c
> src/webui/webui.cpp 9453002
> third_party/libprocess/include/stout/os.hpp 1186d24
>
> Diff: https://reviews.apache.org/r/6146/diff/
>
>
> Testing
> -------
>
> Need more specific tests.
>
> But 'make check' succeeds.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Slave should shutdown properly on exit
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6146/
-----------------------------------------------------------
(Updated July 30, 2012, 11:14 p.m.)
Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.
Changes
-------
jie's comments.
Description
-------
See summary
This addresses bug MESOS-244.
https://issues.apache.org/jira/browse/MESOS-244
Diffs (updated)
-----
src/exec/exec.cpp d60c28d
src/slave/process_based_isolation_module.cpp b54f91c
src/webui/webui.cpp 9453002
third_party/libprocess/include/stout/os.hpp 1186d24
Diff: https://reviews.apache.org/r/6146/diff/
Testing
-------
Need more specific tests.
But 'make check' succeeds.
Thanks,
Vinod Kone