You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/03/19 16:50:26 UTC

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21165


Change subject: Add RE2 2024-03-01 and Abseil
......................................................................

Add RE2 2024-03-01 and Abseil

This adds a build of the latest RE2 release 2024-03-01.
RE2 took a dependency on Abseil starting in 2023-06-01,
so this adds Abseil as well.

Abseil is a C++ library developed by Google that provides
various functionality including string libraries, hash
tables, etc. It is useful on its own.

Abseil's shared library build produces a large number of
shared libraries that depend on each other. This implements
a basic optimization of the symlink_required_libs function
to check the destination directory to see if the required
library has already been symlinked (or is otherwise present).
This makes a big difference in the time take for
symlink_required_libs for Abseil.

Testing:
 - Ran a toolchain build

Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
---
M buildall.sh
M functions.sh
A source/abseil-cpp/build.sh
M source/re2/build.sh
4 files changed, 146 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/65/21165/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21165/1/functions.sh
File functions.sh:

http://gerrit.cloudera.org:8080/#/c/21165/1/functions.sh@640
PS1, Line 640: a shared libraries
> nit: stray plural?
Done


http://gerrit.cloudera.org:8080/#/c/21165/1/functions.sh@641
PS1, Line 641: library
> nit: did you perhaps mean 'directory' here?
Done


http://gerrit.cloudera.org:8080/#/c/21165/1/source/abseil-cpp/build.sh
File source/abseil-cpp/build.sh:

http://gerrit.cloudera.org:8080/#/c/21165/1/source/abseil-cpp/build.sh@2
PS1, Line 2: 2022
> mini-nit: 2024
Done


http://gerrit.cloudera.org:8080/#/c/21165/1/source/re2/build.sh
File source/re2/build.sh:

http://gerrit.cloudera.org:8080/#/c/21165/1/source/re2/build.sh@68
PS1, Line 68: doesnt
> nit: could you also add the long missing apostrophe here?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2024 20:36:03 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................

Add RE2 2024-03-01 and Abseil

This adds a build of the latest RE2 release 2024-03-01.
RE2 took a dependency on Abseil starting in 2023-06-01,
so this adds Abseil as well.

Abseil is a C++ library developed by Google that provides
various functionality including string libraries, hash
tables, etc. It is useful on its own.

Abseil's shared library build produces a large number of
shared libraries that depend on each other. This implements
a basic optimization of the symlink_required_libs function
to check the destination directory to see if the required
library has already been symlinked (or is otherwise present).
This makes a big difference in the time take for
symlink_required_libs for Abseil.

Testing:
 - Ran a toolchain build

Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Reviewed-on: http://gerrit.cloudera.org:8080/21165
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
M functions.sh
A source/abseil-cpp/build.sh
M source/re2/build.sh
4 files changed, 146 insertions(+), 17 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................


Patch Set 3: Code-Review+2

Carry +2


-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2024 20:47:41 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Michael Smith, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21165

to look at the new patch set (#2).

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................

Add RE2 2024-03-01 and Abseil

This adds a build of the latest RE2 release 2024-03-01.
RE2 took a dependency on Abseil starting in 2023-06-01,
so this adds Abseil as well.

Abseil is a C++ library developed by Google that provides
various functionality including string libraries, hash
tables, etc. It is useful on its own.

Abseil's shared library build produces a large number of
shared libraries that depend on each other. This implements
a basic optimization of the symlink_required_libs function
to check the destination directory to see if the required
library has already been symlinked (or is otherwise present).
This makes a big difference in the time take for
symlink_required_libs for Abseil.

Testing:
 - Ran a toolchain build

Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
---
M buildall.sh
M functions.sh
A source/abseil-cpp/build.sh
M source/re2/build.sh
4 files changed, 146 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/65/21165/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................


Patch Set 3: Verified+1

Internal build succeeded


-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2024 15:55:53 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................


Patch Set 2: Code-Review+2

Thank you :)


-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2024 20:39:17 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:55:09 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Add RE2 2024-03-01 and Abseil

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21165 )

Change subject: Add RE2 2024-03-01 and Abseil
......................................................................


Patch Set 1:

(4 comments)

Just a couple of really minor nits

http://gerrit.cloudera.org:8080/#/c/21165/1/functions.sh
File functions.sh:

http://gerrit.cloudera.org:8080/#/c/21165/1/functions.sh@640
PS1, Line 640: a shared libraries
nit: stray plural?


http://gerrit.cloudera.org:8080/#/c/21165/1/functions.sh@641
PS1, Line 641: library
nit: did you perhaps mean 'directory' here?


http://gerrit.cloudera.org:8080/#/c/21165/1/source/abseil-cpp/build.sh
File source/abseil-cpp/build.sh:

http://gerrit.cloudera.org:8080/#/c/21165/1/source/abseil-cpp/build.sh@2
PS1, Line 2: 2022
mini-nit: 2024


http://gerrit.cloudera.org:8080/#/c/21165/1/source/re2/build.sh
File source/re2/build.sh:

http://gerrit.cloudera.org:8080/#/c/21165/1/source/re2/build.sh@68
PS1, Line 68: doesnt
nit: could you also add the long missing apostrophe here?



-- 
To view, visit http://gerrit.cloudera.org:8080/21165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e8a40cb0e5243b68a9abe35a106872bd9bf7f8
Gerrit-Change-Number: 21165
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2024 20:23:08 +0000
Gerrit-HasComments: Yes