[GitHub] [cordova-android] timbru31 commented on a change in pull request #815: Bugfix: Fixes clean command

[GitBox <gi...@apache.org>]

timbru31 commented on a change in pull request #815: Bugfix: Fixes clean command
URL: https://github.com/apache/cordova-android/pull/815#discussion_r317768730
 
 

 ##########
 File path: bin/templates/cordova/lib/builders/ProjectBuilder.js
 ##########
 @@ -51,6 +51,8 @@ class ProjectBuilder {
                 buildCmd = ':app:bundleRelease';
             } else if (cmd === 'debug') {
                 buildCmd = ':app:bundleDebug';
+            } else {
 
 Review comment:
   What about assigning the `cmd` value already to `buildCmd` in line 49? (i.e., `let buildCmd = cmd;`) This would remove the else block and only overwrite the `buildCmd` in the necessary debug and release cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org