You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "VuMartin (via GitHub)" <gi...@apache.org> on 2026/08/25 09:36:06 UTC

[PR] fix(sklearn): rename SVR shrinking parameter [texera]

VuMartin opened a new pull request, #7973:
URL: https://github.com/apache/texera/pull/7973

   ### What changes were proposed in this PR?
   
   Renamed the `probability` parameter to `shrinking` in `SklearnAdvancedSVRParameters`.
   
   The generated Python parameter was already correctly set to `shrinking`; only the displayed parameter name was incorrect.
   
   Before:
   <img width="1023" height="630" alt="Screenshot 2026-08-25 at 1 12 24 AM" src="https://github.com/user-attachments/assets/6160a364-9ff9-42fb-8f60-b43cf7019dce" />
   After:
   <img width="1023" height="630" alt="Screenshot 2026-08-25 at 1 35 53 AM" src="https://github.com/user-attachments/assets/578d14a3-1572-4dd9-ab92-0a63d78375c3" />
   
   **Note:** This renames the enum constant from `probability` to `shrinking`. Existing workflows saved with `probability` will need to be updated.
   
   ### Any related issues, documentation, discussions?
   
   Fixes #7949
   
   ### How was this PR tested?
   
   Tested the Advanced SVM Regressor Trainer with `shrinking = true` and verified that the resulting parameters show `shrinking = True`.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   Generated-by: ChatGPT (5.5 GPT)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5517240922

   The failing check here is not the change: precheck was cancelled on the 25th, which skipped build and left Required Checks red. A rerun should clear it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5518120065

   @aglinxinyuan I think this is ready to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5459413167

   I think this PR is ready to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "VuMartin (via GitHub)" <gi...@apache.org>.
VuMartin commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5518069034

   All core checks passed and the PR is approved. The failing Backport Checks for release/v1.2 appear to be due to a missing CI script in v1.2 (.github/scripts/smoke-boot.sh: No such file or directory).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7973:
URL: https://github.com/apache/texera/pull/7973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5409028452

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@Yicong-Huang`
     You can notify them by mentioning `@Yicong-Huang` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5409446817

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7973?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 92.79%. Comparing base ([`3198595`](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3857ad6`](https://app.codecov.io/gh/apache/texera/commit/3857ad6fe7b5e35139c049d7f10bfc04a82bdbb6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #7973      +/-   ##
   ============================================
   - Coverage     92.79%   92.79%   -0.01%     
     Complexity     4616     4616              
   ============================================
     Files          1174     1174              
     Lines         47453    47452       -1     
     Branches       5304     5304              
   ============================================
   - Hits          44034    44033       -1     
     Misses         1899     1899              
     Partials       1520     1520              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.62% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.12% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.73% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.48% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.03% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.13% <ø> (ø)` | | |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.57% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [3198595](https://app.codecov.io/gh/apache/texera/commit/319859571e30d123a50081a918815d9b65b4300f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7973?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5409028009

   <!-- backport-auto-label-report -->
   ### Backport auto-label report
   
   This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
   
   | Release branch | Analysis |
   | --- | --- |
   | ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
   
   _[Auto-label run](https://github.com/apache/texera/actions/runs/32832827224)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5409430955

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 1 better · 🔴 6 worse · ⚪ 8 noise (<±5%) · 0 without baseline
   
   > Compared against main `2c2c0e5` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/32836855187)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🟢 | bs=10 sw=10 sl=64 | 434 | 0.265 | 22,382/34,535/34,535 us | 🟢 -8.4% / 🔴 +145.5% |
   | 🔴 | bs=100 sw=10 sl=64 | 905 | 0.552 | 105,925/146,313/146,313 us | 🔴 +11.0% / 🔴 +51.6% |
   | 🔴 | bs=1000 sw=10 sl=64 | 1,090 | 0.665 | 914,074/1,046,122/1,046,122 us | 🔴 +11.7% / 🔴 +12.5% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `2c2c0e5` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 434 tuples/sec | 425 tuples/sec | 863.81 tuples/sec | +2.1% | -49.8% |
   | bs=10 sw=10 sl=64 | MB/s | 0.265 MB/s | 0.259 MB/s | 0.527 MB/s | +2.3% | -49.7% |
   | bs=10 sw=10 sl=64 | p50 | 22,382 us | 24,443 us | 11,488 us | -8.4% | +94.8% |
   | bs=10 sw=10 sl=64 | p95 | 34,535 us | 33,438 us | 14,067 us | +3.3% | +145.5% |
   | bs=10 sw=10 sl=64 | p99 | 34,535 us | 33,438 us | 17,591 us | +3.3% | +96.3% |
   | bs=100 sw=10 sl=64 | throughput | 905 tuples/sec | 968 tuples/sec | 1,127 tuples/sec | -6.5% | -19.7% |
   | bs=100 sw=10 sl=64 | MB/s | 0.552 MB/s | 0.591 MB/s | 0.688 MB/s | -6.6% | -19.8% |
   | bs=100 sw=10 sl=64 | p50 | 105,925 us | 102,257 us | 89,893 us | +3.6% | +17.8% |
   | bs=100 sw=10 sl=64 | p95 | 146,313 us | 131,868 us | 96,506 us | +11.0% | +51.6% |
   | bs=100 sw=10 sl=64 | p99 | 146,313 us | 131,868 us | 104,915 us | +11.0% | +39.5% |
   | bs=1000 sw=10 sl=64 | throughput | 1,090 tuples/sec | 1,105 tuples/sec | 1,156 tuples/sec | -1.4% | -5.7% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.665 MB/s | 0.675 MB/s | 0.705 MB/s | -1.5% | -5.7% |
   | bs=1000 sw=10 sl=64 | p50 | 914,074 us | 909,827 us | 886,448 us | +0.5% | +3.1% |
   | bs=1000 sw=10 sl=64 | p95 | 1,046,122 us | 936,542 us | 930,093 us | +11.7% | +12.5% |
   | bs=1000 sw=10 sl=64 | p99 | 1,046,122 us | 936,542 us | 963,104 us | +11.7% | +8.6% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,460.91,200,128000,434,0.265,22381.85,34534.50,34534.50
   1,100,10,64,20,2210.33,2000,1280000,905,0.552,105925.45,146313.44,146313.44
   2,1000,10,64,20,18347.87,20000,12800000,1090,0.665,914074.17,1046122.42,1046122.42
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(sklearn): rename SVR shrinking parameter [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7973:
URL: https://github.com/apache/texera/pull/7973#issuecomment-5519103651

   Backport PR opened: draft #8371 (https://github.com/apache/texera/pull/8371) to `release/v1.2`, assigned to @VuMartin — needs manual work because the backported tree failed its pre-merge build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org