You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/24 16:14:09 UTC
[GitHub] [incubator-seatunnel] laglangyue opened a new pull request, #2518: array transfer for spark
laglangyue opened a new pull request, #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
fix the ArrayType translate for spark2.4.0
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2518: [core][fix] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#issuecomment-1225958977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2518: [core][fix] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#issuecomment-1225946216
this PR should be after This PR should be after console optimization. I have tested some data types in the local rebase PR # 2516, but I have not written unit tests. I will add some unit tests for this PR later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954482199
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/serialization/RowConverter.java:
##########
@@ -124,5 +124,5 @@ protected boolean validate(Object field, SeaTunnelDataType<?> dataType) {
*
* @throws IOException Thrown, if the conversion fails.
*/
- public abstract SeaTunnelRow convert(T engineRow) throws IOException;
+ public abstract SeaTunnelRow reconvert(T engineRow) throws IOException;
Review Comment:
It should be because the reconvert method that is called inside the implementation class is called, and the name is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
laglangyue commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954912404
##########
seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf:
##########
@@ -36,7 +36,7 @@ source {
schema = {
fields {
c_map = "map<string, string>"
Review Comment:
yes, it is. I will fix in another PR，not enough time for one day to fix it all. Besides and same to Date type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954481166
##########
seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf:
##########
@@ -36,7 +36,7 @@ source {
schema = {
fields {
c_map = "map<string, string>"
Review Comment:
Is there nothing wrong with MAP? Don't it need to convert to MapData?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954749014
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/serialization/RowConverter.java:
##########
@@ -124,5 +124,5 @@ protected boolean validate(Object field, SeaTunnelDataType<?> dataType) {
*
* @throws IOException Thrown, if the conversion fails.
*/
- public abstract SeaTunnelRow convert(T engineRow) throws IOException;
+ public abstract SeaTunnelRow reconvert(T engineRow) throws IOException;
Review Comment:
> Why need to be renamed?
The same problem as @hailin0 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954913774
##########
seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf:
##########
@@ -36,7 +36,7 @@ source {
schema = {
fields {
c_map = "map<string, string>"
Review Comment:
OK, thanks for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954430371
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/serialization/RowConverter.java:
##########
@@ -124,5 +124,5 @@ protected boolean validate(Object field, SeaTunnelDataType<?> dataType) {
*
* @throws IOException Thrown, if the conversion fails.
*/
- public abstract SeaTunnelRow convert(T engineRow) throws IOException;
+ public abstract SeaTunnelRow reconvert(T engineRow) throws IOException;
Review Comment:
Why need to be renamed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org