You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/27 12:24:52 UTC
[GitHub] [maven-checkstyle-plugin] elharo commented on a change in pull
request #18: [MCHECKSTYLE-381] remove call to checker.setClassLoader().
elharo commented on a change in pull request #18: [MCHECKSTYLE-381] remove call to checker.setClassLoader().
URL: https://github.com/apache/maven-checkstyle-plugin/pull/18#discussion_r385092808
##########
File path: src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
##########
@@ -316,6 +258,73 @@ public URLClassLoader run()
return checkerListener.getResults();
}
+ private void setUpCheckstyleClassloader( Checker checker,
+ List<String> classPathStrings,
+ List<String> outputDirectories )
+ throws CheckstyleExecutorException
+ {
+ final List<URL> urls = new ArrayList<>( classPathStrings.size() );
+
+ for ( String path : classPathStrings )
+ {
+ try
+ {
+ urls.add( new File( path ).toURI().toURL() );
+ }
+ catch ( MalformedURLException e )
+ {
+ throw new CheckstyleExecutorException( e.getMessage(), e );
+ }
+ }
+
+ for ( String outputDirectoryString : outputDirectories )
+ {
+ try
+ {
+ if ( outputDirectoryString != null )
+ {
+ File outputDirectoryFile = new File( outputDirectoryString );
+ if ( outputDirectoryFile.exists() )
+ {
+ URL outputDirectoryUrl = outputDirectoryFile.toURI().toURL();
+ getLogger().debug( "Adding the outputDirectory " + outputDirectoryUrl.toString()
Review comment:
not sure this log message carries its weight
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services