You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/29 05:36:09 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.
zhijiangW commented on a change in pull request #12353:
URL: https://github.com/apache/flink/pull/12353#discussion_r432264824
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java
##########
@@ -130,7 +132,7 @@ public BufferBuilder requestNewBufferBuilder(int targetChannel) throws IOExcepti
BufferBuilder builder = super.requestNewBufferBuilder(targetChannel);
if (randomTriggered) {
- addBufferConsumer(builder.createBufferConsumer(), targetChannel);
+ addBufferConsumer(randomConsumer = builder.createBufferConsumer(), targetChannel);
Review comment:
I think we should not construct the consumer before filling the `BufferBuilder`, otherwise the random emitted latency marker is also visible for all the other channels, which breaks the previous assumption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org