You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/03 11:34:51 UTC
[GitHub] [tvm] liangW-intellif opened a new pull request, #13278: [BugFix][Pattern] Fixed a crash when AltPattern and FunctionPattern are used nested
liangW-intellif opened a new pull request, #13278:
URL: https://github.com/apache/tvm/pull/13278
The PatternGroup doesn not check if the FunctionPattern is matched while processing the FunctionPattern, but when FunctionPattern is nested with AltPattern, the FunctionPattern may not be matched, resulting in a crash when looking up matched nodes.
This commit adds a check at handling FunctionPattern to fix this crash, same as the checks at handling other patterns(such as `dataflow_matcher.cc:667`)
cc @wrongtest-intellif
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13278: [BugFix][Pattern] Fixed a crash when AltPattern and FunctionPattern are used nested
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13278:
URL: https://github.com/apache/tvm/pull/13278#issuecomment-1301970744
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `bugfix`, `pattern` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #13278: [BugFix][Pattern] Fixed a crash when AltPattern and FunctionPattern are used nested
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13278:
URL: https://github.com/apache/tvm/pull/13278#issuecomment-1302600621
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #13278: [BugFix][Pattern] Fixed a crash when AltPattern and FunctionPattern are used nested
Posted by GitBox <gi...@apache.org>.
masahi merged PR #13278:
URL: https://github.com/apache/tvm/pull/13278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org