You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/06/22 14:32:18 UTC

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2146
  
    Really good work @zentol. I had some minor comments concerning the instantiation of the `MetricRegistry` for the `JobManager` and some clarifications. I think it would be good if we could add some test cases which check, for example, that we report the correct checkpoint size and duration.
    
    Maybe you could also rebase this PR on the referred PR #2145. Then it would be easier to test the job manager metrics on a local machine. I would like to do it before merging. But once this is done, then I think we're good to merge your PR :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---