You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by peterkim95 <gi...@git.apache.org> on 2016/08/29 22:25:36 UTC
[GitHub] incubator-eagle pull request #403: EAGLE-510: Refactor HDFS audit log parser
GitHub user peterkim95 opened a pull request:
https://github.com/apache/incubator-eagle/pull/403
EAGLE-510: Refactor HDFS audit log parser
https://issues.apache.org/jira/browse/EAGLE-510
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peterkim95/incubator-eagle hdfslogparse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #403
----
commit b73307585bf1089e5090c30ae1ed623ce98727f7
Author: Peter Kim <pe...@paypal.com>
Date: 2016-08-29T22:17:37Z
rewrite hdfs log parsing logic with regex
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #403: EAGLE-510: Refactor HDFS audit log parser
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:
https://github.com/apache/incubator-eagle/pull/403
We may not change the code to use regex matching as it is too slow. We have achieved more than 10 times performance gain by using string operations than using regex.
This is critical important as in production we have the issue with large amount of audit log and regex significantly make performance worse
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #403: EAGLE-510: Refactor HDFS audit log parser
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:
https://github.com/apache/incubator-eagle/pull/403
sure, we can remove that method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #403: EAGLE-510: Refactor HDFS audit log parser
Posted by peterkim95 <gi...@git.apache.org>.
Github user peterkim95 commented on the issue:
https://github.com/apache/incubator-eagle/pull/403
I see, can we can still refactor by removing the unused method parseUser
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #403: EAGLE-510: Refactor HDFS audit log parser
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---