[GitHub] [arrow] aucahuasi commented on a change in pull request #11541: ARROW-13081: [C++] Disallow comparing zoned and naive timestamps

[GitBox <gi...@apache.org>]

aucahuasi commented on a change in pull request #11541:
URL: https://github.com/apache/arrow/pull/11541#discussion_r739547812



##########
File path: cpp/src/arrow/compute/kernels/scalar_compare_test.cc
##########
@@ -454,6 +454,54 @@ TEST(TestCompareTimestamps, Basics) {
   CheckArrayCase(seconds_utc, CompareOperator::EQUAL, "[false, false, true]");
 }
 
+TEST(TestCompareTimestamps, DifferentParameters) {
+  const std::vector<std::pair<std::string, std::string>> cases = {
+      {"equal", "[0, 0, 1]"},   {"not_equal", "[1, 1, 0]"},
+      {"less", "[1, 0, 0]"},    {"less_equal", "[1, 0, 1]"},
+      {"greater", "[0, 1, 0]"}, {"greater_equal", "[0, 1, 1]"},
+  };
+  const std::string lhs_json = R"(["1970-01-01","2000-02-29","1900-02-28"])";
+  const std::string rhs_json = R"(["1970-01-02","2000-02-01","1900-02-28"])";
+
+  for (const auto& op : cases) {
+    const auto& function = op.first;
+    const auto& expected = op.second;
+
+    SCOPED_TRACE(function);
+    {
+      // Different units should be fine

Review comment:
       The logic in these blocks can be a protected method/util in `TestCompareTimestamps`, so the test can be simplified a little bit
   Something like https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/aggregate_test.cc#L883
   `TestCountDistinctKernel::Check`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org