You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Andrew Jaquith <an...@gmail.com> on 2009/03/06 14:10:56 UTC
JCR commit
I'd like to congratulate Janne on his checkin of the JCR code. It, and
the from-scratch Priha implementation that underpins it, are
remarkable achievements. Nice work!
Yes, there are bunches of tests that need fixing. But that's ok. We'll
fix 'em.
My own next batch of checkins will include a rewritten Edit.jsp and
attachment uploads, including (for the first time) multiple
attachments. This is implemented using ActionBeans, and it means
AttachmentServlet's days are numbered. :)
Andrew
Re: JCR commit
Posted by Janne Jalkanen <ja...@ecyrd.com>.
For example, ImagePlugin could instantiate a
DynamicAttachmentProvider, then generate a thumbnail and dump it to
the DynamicAttachmentProvider, without it actually ending up in the
repository and polluting it.
Dynamic Attachments don't show in the RecentChanges or when listing
page attachments, but they are accessible via the /attach/ URL and are
subject to all ACL restrictions of the parent page, just like a
regular attachment would.
It is a generic (and fairly simple) way of allowing components to
create Wiki content on-the-fly. However, at the moment it's limited
to Attachments only - it could be any WikiPage. For example, you could
have dynamic templates (e.g. when creating new page content),
thumbnails or PDF generation done fairly easily with this mechanism.
It's been around 2.6, but I don't think anyone's using it much. I've
been meaning to but haven't had the chance yet.
/Janne
On 6 Mar 2009, at 18:19, Andrew Jaquith wrote:
> Dynamic-anything is usually a pretty bad name. What do
> DynamicAttachments do?
>
> On Fri, Mar 6, 2009 at 11:03 AM, Janne Jalkanen
> <Ja...@ecyrd.com> wrote:
>>
>> Oh goody, then I don't have to worry about fixing any issues with
>> it :-D
>>
>> (BTW, anybody want to take the job of turning DynamicAttachments into
>> something more generic?)
>>
>> /Janne
>>
>> On Mar 6, 2009, at 15:10 , Andrew Jaquith wrote:
>>
>>> I'd like to congratulate Janne on his checkin of the JCR code. It,
>>> and the
>>> from-scratch Priha implementation that underpins it, are remarkable
>>> achievements. Nice work!
>>>
>>> Yes, there are bunches of tests that need fixing. But that's ok.
>>> We'll fix
>>> 'em.
>>>
>>> My own next batch of checkins will include a rewritten Edit.jsp and
>>> attachment uploads, including (for the first time) multiple
>>> attachments.
>>> This is implemented using ActionBeans, and it means
>>> AttachmentServlet's days
>>> are numbered. :)
>>>
>>> Andrew
>>
>>
Re: JCR commit
Posted by Andrew Jaquith <an...@gmail.com>.
Dynamic-anything is usually a pretty bad name. What do DynamicAttachments do?
On Fri, Mar 6, 2009 at 11:03 AM, Janne Jalkanen
<Ja...@ecyrd.com> wrote:
>
> Oh goody, then I don't have to worry about fixing any issues with it :-D
>
> (BTW, anybody want to take the job of turning DynamicAttachments into
> something more generic?)
>
> /Janne
>
> On Mar 6, 2009, at 15:10 , Andrew Jaquith wrote:
>
>> I'd like to congratulate Janne on his checkin of the JCR code. It, and the
>> from-scratch Priha implementation that underpins it, are remarkable
>> achievements. Nice work!
>>
>> Yes, there are bunches of tests that need fixing. But that's ok. We'll fix
>> 'em.
>>
>> My own next batch of checkins will include a rewritten Edit.jsp and
>> attachment uploads, including (for the first time) multiple attachments.
>> This is implemented using ActionBeans, and it means AttachmentServlet's days
>> are numbered. :)
>>
>> Andrew
>
>
Re: JCR commit
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Oh goody, then I don't have to worry about fixing any issues with it :-D
(BTW, anybody want to take the job of turning DynamicAttachments into
something more generic?)
/Janne
On Mar 6, 2009, at 15:10 , Andrew Jaquith wrote:
> I'd like to congratulate Janne on his checkin of the JCR code. It,
> and the from-scratch Priha implementation that underpins it, are
> remarkable achievements. Nice work!
>
> Yes, there are bunches of tests that need fixing. But that's ok.
> We'll fix 'em.
>
> My own next batch of checkins will include a rewritten Edit.jsp and
> attachment uploads, including (for the first time) multiple
> attachments. This is implemented using ActionBeans, and it means
> AttachmentServlet's days are numbered. :)
>
> Andrew