You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/16 17:01:38 UTC

[GitHub] [spark] dongjoon-hyun commented on pull request #31848: [SPARK-34756][SQL] Fix FileScan equality check

dongjoon-hyun commented on pull request #31848:
URL: https://github.com/apache/spark/pull/31848#issuecomment-800441357


   Thank you, @peter-toth . I prefer a simple one focusing on `.equals()` only.
   
   > @dongjoon-hyun, you asked for a UT in [#31820 (review)](https://github.com/apache/spark/pull/31820#pullrequestreview-612593409), shall I create a simple one focusing on `.equals()` (I wonder where is the right place for such a test?) or shall shall I create an e2e test where a correctness issue is shown and fixed?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org