[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7847: Replace e2e cases to e2e-v2: Lua Nginx/SelfObservability.

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #7847:
URL: https://github.com/apache/skywalking/pull/7847#discussion_r725747239



##########
File path: test/e2e-v2/cases/simple/expected/metrics-has-value.yml
##########
@@ -16,4 +16,4 @@
 {{- contains . }}
 - key: {{ notEmpty .key }}
   value: {{ ge .value 1 }}
-{{- end }}
+{{- end }}

Review comment:
       Can you set the IDE and keep the new lines at the end of files? You can search on Google [why we prefer a new line at the end of a file](https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline)?
   
   <img width="504" alt="Screen Shot 2021-10-11 at 10 13 42" src="https://user-images.githubusercontent.com/15965696/136723843-81871493-eeea-4729-9bbc-fb8eefda5f8d.png">
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org