You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/16 23:00:18 UTC

[GitHub] [ozone] yuangu002 opened a new pull request #2539: HDDS-5616. [Dev Support] Add a shell script to automate docker-up with FSO-enabled

yuangu002 opened a new pull request #2539:
URL: https://github.com/apache/ozone/pull/2539


   ## What changes were proposed in this pull request?
   
   Add a shell script to automate docker-up with FSO enabled.
   Update README instructions.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5616
   
   ## How was this patch tested?
   Tested on clusters.
   
   cc @avijayanhwx @smengcl 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx merged pull request #2539: HDDS-5616. Document how to run ozone sample cluster with FSO-enabled

Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #2539:
URL: https://github.com/apache/ozone/pull/2539


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] yuangu002 commented on pull request #2539: HDDS-5616. [Dev Support] Add a shell script to automate docker-up with FSO-enabled

Posted by GitBox <gi...@apache.org>.
yuangu002 commented on pull request #2539:
URL: https://github.com/apache/ozone/pull/2539#issuecomment-900512878


   > Thanks @yuangu002 for thinking about improving developer experience.
   > 
   > I don't think we need a separate script for such logic. It definitely does not belong to the root directory and README, since it is specific to the `ozone` compose environment.
   > 
   > Instead of adding the new script, we can define these variables in existing `run.sh` for documentation purpose. We may also consider enabling FSO as default in `run.sh`.
   > 
   > https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/main/compose/ozone/run.sh
   
   Thanks @adoroszlai for taking a look. I have reverted back all root directory level changes. Could you take another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] yuangu002 commented on pull request #2539: HDDS-5616. [Dev Support] Add a shell script to automate docker-up with FSO-enabled

Posted by GitBox <gi...@apache.org>.
yuangu002 commented on pull request #2539:
URL: https://github.com/apache/ozone/pull/2539#issuecomment-900512878


   > Thanks @yuangu002 for thinking about improving developer experience.
   > 
   > I don't think we need a separate script for such logic. It definitely does not belong to the root directory and README, since it is specific to the `ozone` compose environment.
   > 
   > Instead of adding the new script, we can define these variables in existing `run.sh` for documentation purpose. We may also consider enabling FSO as default in `run.sh`.
   > 
   > https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/main/compose/ozone/run.sh
   
   Thanks @adoroszlai for taking a look. I have reverted back all root directory level changes. Could you take another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #2539: HDDS-5616. Document how to run ozone sample cluster with FSO-enabled

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #2539:
URL: https://github.com/apache/ozone/pull/2539#issuecomment-901430061


   Thanks for the patch @yuangu002, and the review @adoroszlai.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org