You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zach Amsden (Code Review)" <ge...@cloudera.org> on 2017/11/27 23:47:11 UTC

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0 

Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8656


Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................

IMPALA-6244: Fix test failures with Hadoop 3.0

The metadata query test fails when run against Hadoop 3.0 due to
some defaults changing for sequence files.

Testing: Compared the output of
 hadoop fs -text
/test-warehouse/alltypesmixedformat/year=2009/month=2/000023_0
 and verified it is the same after a data load on Hadoop 2.6 and
 Hadoop 3.0; ran the metadata query test and verified it now
 passes in both cases.

Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
---
M testdata/workloads/functional-query/queries/QueryTest/show-stats.test
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/8656/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Tim Wood (Code Review)" <ge...@cloudera.org>.
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
The whole number part could exceed 58 depending on the value of the number that matches the pattern in the 2nd row.



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 22:09:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@85
PS2, Line 85: ---- RESULTS: VERIFY_IS_EQUAL
VERIFY_IS_EQUAL should not be needed


http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@86
PS2, Line 86: '2009','1',-1,1,'19.59KB','NOT CACHED','NOT CACHED','TEXT','false','$NAMENODE/test-warehouse/alltypesmixedformat/year=2009/month=1'
just change them all



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:44:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................

IMPALA-6244: Fix test failures with Hadoop 3.0

The metadata query test fails when run against Hadoop 3.0 due to
some defaults changing for sequence files.

Testing: Compared the output of
 hadoop fs -text
/test-warehouse/alltypesmixedformat/year=2009/month=2/000023_0
 and verified it is the same after a data load on Hadoop 2.6 and
 Hadoop 3.0; ran the metadata query test and verified it now
 passes in both cases.

Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Reviewed-on: http://gerrit.cloudera.org:8080/8656
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/workloads/functional-query/queries/QueryTest/show-stats.test
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 4
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, David Knupp, Tim Wood, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8656

to look at the new patch set (#2).

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................

IMPALA-6244: Fix test failures with Hadoop 3.0

The metadata query test fails when run against Hadoop 3.0 due to
some defaults changing for sequence files.

Testing: Compared the output of
 hadoop fs -text
/test-warehouse/alltypesmixedformat/year=2009/month=2/000023_0
 and verified it is the same after a data load on Hadoop 2.6 and
 Hadoop 3.0; ran the metadata query test and verified it now
 passes in both cases.

Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
---
M testdata/workloads/functional-query/queries/QueryTest/show-stats.test
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/8656/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 07:33:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1544/


-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 04:13:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
> A long shot, admittedly; I think you're OK with 2nd row <=21.98. :)
I think it should be fine; if it changes radically, we'd probably like to know why anyway.


http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
> why not use column regex like in the other tests in this file?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:35:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
> A long shot, admittedly; I think you're OK with 2nd row <=21.98. :)
why not use column regex like in the other tests in this file?



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:27:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 2:

> (2 comments)

Sigh, bad link - here is the permalink:

https://github.com/cloudera/Impala/blob/9bc3d19e331a871b18dd4cb91734b841473f58fa/tests/common/test_result_verifier.py#L385


-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 03:47:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, David Knupp, Tim Wood, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8656

to look at the new patch set (#3).

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................

IMPALA-6244: Fix test failures with Hadoop 3.0

The metadata query test fails when run against Hadoop 3.0 due to
some defaults changing for sequence files.

Testing: Compared the output of
 hadoop fs -text
/test-warehouse/alltypesmixedformat/year=2009/month=2/000023_0
 and verified it is the same after a data load on Hadoop 2.6 and
 Hadoop 3.0; ran the metadata query test and verified it now
 passes in both cases.

Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
---
M testdata/workloads/functional-query/queries/QueryTest/show-stats.test
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/8656/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@85
PS2, Line 85: ---- RESULTS: VERIFY_IS_EQUAL
> VERIFY_IS_EQUAL should not be needed
False, if using row_regex.

Somewhat true if using column regex and this is a late enough column to be distinct.

The problem is that rows will be sorted by default if VERIFY_IS_EQUAL is not provided, and the sort does not take any accounting for the presence of regular expressions in either rows or columns.

https://github.com/cloudera/Impala/blob/cdh5-trunk/tests/common/test_result_verifier.py#L385


http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@86
PS2, Line 86: '2009','1',-1,1,'19.59KB','NOT CACHED','NOT CACHED','TEXT','false','$NAMENODE/test-warehouse/alltypesmixedformat/year=2009/month=1'
> just change them all
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 03:45:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 04:10:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 1: Code-Review+1

Thanks. Looks straight-forward to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 03:33:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6244: Fix test failures with Hadoop 3.0

Posted by "Tim Wood (Code Review)" <ge...@cloudera.org>.
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )

Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test
File testdata/workloads/functional-query/queries/QueryTest/show-stats.test:

http://gerrit.cloudera.org:8080/#/c/8656/1/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@89
PS1, Line 89: row_regex:'Total','',-1,3,'58.[0-9][0-9]KB','0B','','','',''
> The whole number part could exceed 58 depending on the value of the number 
A long shot, admittedly; I think you're OK with 2nd row <=21.98. :)



-- 
To view, visit http://gerrit.cloudera.org:8080/8656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6
Gerrit-Change-Number: 8656
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 22:11:33 +0000
Gerrit-HasComments: Yes