You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/13 06:53:53 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #12411: Minor: [Integration] Privatized some code in tests
jorgecarleitao opened a new pull request #12411:
URL: https://github.com/apache/arrow/pull/12411
Also reformatted with black, since other parts of our code base also use it (and it is convenient)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1041114093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12411:
URL: https://github.com/apache/arrow/pull/12411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#discussion_r810331784
##########
File path: dev/archery/archery/integration/runner.py
##########
@@ -18,6 +18,7 @@
from collections import namedtuple
from concurrent.futures import ThreadPoolExecutor
from functools import partial
+from typing import Callable, List
Review comment:
fixed.
Without a linter it is a bit difficult to keep consistency - e.g. `archery/bot.py` has
```python
import os
import shlex
from pathlib import Path
from functools import partial
import tempfile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1047905983
Benchmark runs are scheduled for baseline = a061a921db02eec9f1e31acacdbdc6a1c96d5b67 and contender = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1. 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e0c9073711684888921e1c11094b0677...47a9f3ddb2e547e181e0f5c92572f935/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d1d207eb822b4d3684acf8c5e0c9e297...c6597e5a8b8f4ed392a27c60ab36b8a3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a143298a72d541bfa766a58633c6f2c0...9ca02c7c57f74129adcea8004eaf9e9b/)
[Finished :arrow_down:0.21% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6022b36f6744468099867f9d7d5b4a27...a891d30f4cfc48ba830fe794b2e14da6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#discussion_r811975386
##########
File path: dev/archery/archery/integration/runner.py
##########
@@ -18,6 +18,7 @@
from collections import namedtuple
from concurrent.futures import ThreadPoolExecutor
from functools import partial
+from typing import Callable, List
Review comment:
True. This is more of a best effort thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12411: MINOR: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1040942450
There are too many changes to say "MINOR": https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#minor-fixes
Could you open a JIRA issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1047905983
Benchmark runs are scheduled for baseline = a061a921db02eec9f1e31acacdbdc6a1c96d5b67 and contender = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1. 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e0c9073711684888921e1c11094b0677...47a9f3ddb2e547e181e0f5c92572f935/)
[Finished :arrow_down:0.29% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d1d207eb822b4d3684acf8c5e0c9e297...c6597e5a8b8f4ed392a27c60ab36b8a3/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a143298a72d541bfa766a58633c6f2c0...9ca02c7c57f74129adcea8004eaf9e9b/)
[Finished :arrow_down:0.21% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6022b36f6744468099867f9d7d5b4a27...a891d30f4cfc48ba830fe794b2e14da6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#discussion_r811978636
##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -23,39 +23,46 @@
from .util import run_cmd, ARROW_ROOT_DEFAULT, log
+_EXE_PATH = os.environ.get(
+ "ARROW_CPP_EXE_PATH", os.path.join(ARROW_ROOT_DEFAULT, "cpp/build/debug")
+)
+_INTEGRATION_EXE = os.path.join(_EXE_PATH, "arrow-json-integration-test")
+_STREAM_TO_FILE = os.path.join(_EXE_PATH, "arrow-stream-to-file")
+_FILE_TO_STREAM = os.path.join(_EXE_PATH, "arrow-file-to-stream")
+
+_FLIGHT_SERVER_CMD = [os.path.join(
+ _EXE_PATH, "flight-test-integration-server")]
+_FLIGHT_CLIENT_CMD = [
+ os.path.join(_EXE_PATH, "flight-test-integration-client"),
+ "-host",
+ "localhost",
+]
+
+
class CPPTester(Tester):
PRODUCER = True
CONSUMER = True
FLIGHT_SERVER = True
FLIGHT_CLIENT = True
- EXE_PATH = os.environ.get(
- 'ARROW_CPP_EXE_PATH',
- os.path.join(ARROW_ROOT_DEFAULT, 'cpp/build/debug'))
-
- CPP_INTEGRATION_EXE = os.path.join(EXE_PATH, 'arrow-json-integration-test')
- STREAM_TO_FILE = os.path.join(EXE_PATH, 'arrow-stream-to-file')
- FILE_TO_STREAM = os.path.join(EXE_PATH, 'arrow-file-to-stream')
-
- FLIGHT_SERVER_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-server')]
- FLIGHT_CLIENT_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-client'),
- "-host", "localhost"]
-
- name = 'C++'
+ name = "C++"
- def _run(self, arrow_path=None, json_path=None, command='VALIDATE',
- quirks=None):
- cmd = [self.CPP_INTEGRATION_EXE, '--integration']
+ def _run(
+ self,
+ arrow_path=None,
+ json_path=None,
+ command="VALIDATE",
+ quirks=None
+ ):
Review comment:
You should be able to use `archery lint --python --fix`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12411: Minor: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1037863905
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12411: MINOR: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1037863905
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12411: Minor: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1037863905
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1041114132
@kou , thanks. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#discussion_r810330188
##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -23,39 +23,46 @@
from .util import run_cmd, ARROW_ROOT_DEFAULT, log
+_EXE_PATH = os.environ.get(
+ "ARROW_CPP_EXE_PATH", os.path.join(ARROW_ROOT_DEFAULT, "cpp/build/debug")
+)
+_INTEGRATION_EXE = os.path.join(_EXE_PATH, "arrow-json-integration-test")
+_STREAM_TO_FILE = os.path.join(_EXE_PATH, "arrow-stream-to-file")
+_FILE_TO_STREAM = os.path.join(_EXE_PATH, "arrow-file-to-stream")
+
+_FLIGHT_SERVER_CMD = [os.path.join(
+ _EXE_PATH, "flight-test-integration-server")]
+_FLIGHT_CLIENT_CMD = [
+ os.path.join(_EXE_PATH, "flight-test-integration-client"),
+ "-host",
+ "localhost",
+]
+
+
class CPPTester(Tester):
PRODUCER = True
CONSUMER = True
FLIGHT_SERVER = True
FLIGHT_CLIENT = True
- EXE_PATH = os.environ.get(
- 'ARROW_CPP_EXE_PATH',
- os.path.join(ARROW_ROOT_DEFAULT, 'cpp/build/debug'))
-
- CPP_INTEGRATION_EXE = os.path.join(EXE_PATH, 'arrow-json-integration-test')
- STREAM_TO_FILE = os.path.join(EXE_PATH, 'arrow-stream-to-file')
- FILE_TO_STREAM = os.path.join(EXE_PATH, 'arrow-file-to-stream')
-
- FLIGHT_SERVER_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-server')]
- FLIGHT_CLIENT_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-client'),
- "-host", "localhost"]
-
- name = 'C++'
+ name = "C++"
- def _run(self, arrow_path=None, json_path=None, command='VALIDATE',
- quirks=None):
- cmd = [self.CPP_INTEGRATION_EXE, '--integration']
+ def _run(
+ self,
+ arrow_path=None,
+ json_path=None,
+ command="VALIDATE",
+ quirks=None
+ ):
+ cmd = [_INTEGRATION_EXE, "--integration"]
if arrow_path is not None:
- cmd.append('--arrow=' + arrow_path)
+ cmd.append("--arrow=" + arrow_path)
Review comment:
I use black on save my editor and did not even notice these changes. Reverted. Sorry for the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1047905983
Benchmark runs are scheduled for baseline = a061a921db02eec9f1e31acacdbdc6a1c96d5b67 and contender = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1. 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e0c9073711684888921e1c11094b0677...47a9f3ddb2e547e181e0f5c92572f935/)
[Finished :arrow_down:0.29% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d1d207eb822b4d3684acf8c5e0c9e297...c6597e5a8b8f4ed392a27c60ab36b8a3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a143298a72d541bfa766a58633c6f2c0...9ca02c7c57f74129adcea8004eaf9e9b/)
[Finished :arrow_down:0.21% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6022b36f6744468099867f9d7d5b4a27...a891d30f4cfc48ba830fe794b2e14da6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#discussion_r809064478
##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -23,39 +23,46 @@
from .util import run_cmd, ARROW_ROOT_DEFAULT, log
+_EXE_PATH = os.environ.get(
+ "ARROW_CPP_EXE_PATH", os.path.join(ARROW_ROOT_DEFAULT, "cpp/build/debug")
+)
+_INTEGRATION_EXE = os.path.join(_EXE_PATH, "arrow-json-integration-test")
+_STREAM_TO_FILE = os.path.join(_EXE_PATH, "arrow-stream-to-file")
+_FILE_TO_STREAM = os.path.join(_EXE_PATH, "arrow-file-to-stream")
+
+_FLIGHT_SERVER_CMD = [os.path.join(
+ _EXE_PATH, "flight-test-integration-server")]
+_FLIGHT_CLIENT_CMD = [
+ os.path.join(_EXE_PATH, "flight-test-integration-client"),
+ "-host",
+ "localhost",
+]
+
+
class CPPTester(Tester):
PRODUCER = True
CONSUMER = True
FLIGHT_SERVER = True
FLIGHT_CLIENT = True
- EXE_PATH = os.environ.get(
- 'ARROW_CPP_EXE_PATH',
- os.path.join(ARROW_ROOT_DEFAULT, 'cpp/build/debug'))
-
- CPP_INTEGRATION_EXE = os.path.join(EXE_PATH, 'arrow-json-integration-test')
- STREAM_TO_FILE = os.path.join(EXE_PATH, 'arrow-stream-to-file')
- FILE_TO_STREAM = os.path.join(EXE_PATH, 'arrow-file-to-stream')
-
- FLIGHT_SERVER_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-server')]
- FLIGHT_CLIENT_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-client'),
- "-host", "localhost"]
-
- name = 'C++'
+ name = "C++"
- def _run(self, arrow_path=None, json_path=None, command='VALIDATE',
- quirks=None):
- cmd = [self.CPP_INTEGRATION_EXE, '--integration']
+ def _run(
+ self,
+ arrow_path=None,
+ json_path=None,
+ command="VALIDATE",
+ quirks=None
+ ):
Review comment:
Is this the product of running a style checker? It seems the outcome is a net negative (a lot of additional vertical space).
##########
File path: dev/archery/archery/integration/runner.py
##########
@@ -18,6 +18,7 @@
from collections import namedtuple
from concurrent.futures import ThreadPoolExecutor
from functools import partial
+from typing import Callable, List
Review comment:
Can you keep the imports alphabetically ordered, i.e. move `typing` after `traceback` below?
##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -23,39 +23,46 @@
from .util import run_cmd, ARROW_ROOT_DEFAULT, log
+_EXE_PATH = os.environ.get(
+ "ARROW_CPP_EXE_PATH", os.path.join(ARROW_ROOT_DEFAULT, "cpp/build/debug")
+)
+_INTEGRATION_EXE = os.path.join(_EXE_PATH, "arrow-json-integration-test")
+_STREAM_TO_FILE = os.path.join(_EXE_PATH, "arrow-stream-to-file")
+_FILE_TO_STREAM = os.path.join(_EXE_PATH, "arrow-file-to-stream")
+
+_FLIGHT_SERVER_CMD = [os.path.join(
+ _EXE_PATH, "flight-test-integration-server")]
+_FLIGHT_CLIENT_CMD = [
+ os.path.join(_EXE_PATH, "flight-test-integration-client"),
+ "-host",
+ "localhost",
+]
+
+
class CPPTester(Tester):
PRODUCER = True
CONSUMER = True
FLIGHT_SERVER = True
FLIGHT_CLIENT = True
- EXE_PATH = os.environ.get(
- 'ARROW_CPP_EXE_PATH',
- os.path.join(ARROW_ROOT_DEFAULT, 'cpp/build/debug'))
-
- CPP_INTEGRATION_EXE = os.path.join(EXE_PATH, 'arrow-json-integration-test')
- STREAM_TO_FILE = os.path.join(EXE_PATH, 'arrow-stream-to-file')
- FILE_TO_STREAM = os.path.join(EXE_PATH, 'arrow-file-to-stream')
-
- FLIGHT_SERVER_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-server')]
- FLIGHT_CLIENT_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-client'),
- "-host", "localhost"]
-
- name = 'C++'
+ name = "C++"
- def _run(self, arrow_path=None, json_path=None, command='VALIDATE',
- quirks=None):
- cmd = [self.CPP_INTEGRATION_EXE, '--integration']
+ def _run(
+ self,
+ arrow_path=None,
+ json_path=None,
+ command="VALIDATE",
+ quirks=None
+ ):
+ cmd = [_INTEGRATION_EXE, "--integration"]
if arrow_path is not None:
- cmd.append('--arrow=' + arrow_path)
+ cmd.append("--arrow=" + arrow_path)
Review comment:
Such gratuitous style changes will pollute the git history and make `git annotate` less useful. I don't know if it's easy for you to undo them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#discussion_r810329868
##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -23,39 +23,46 @@
from .util import run_cmd, ARROW_ROOT_DEFAULT, log
+_EXE_PATH = os.environ.get(
+ "ARROW_CPP_EXE_PATH", os.path.join(ARROW_ROOT_DEFAULT, "cpp/build/debug")
+)
+_INTEGRATION_EXE = os.path.join(_EXE_PATH, "arrow-json-integration-test")
+_STREAM_TO_FILE = os.path.join(_EXE_PATH, "arrow-stream-to-file")
+_FILE_TO_STREAM = os.path.join(_EXE_PATH, "arrow-file-to-stream")
+
+_FLIGHT_SERVER_CMD = [os.path.join(
+ _EXE_PATH, "flight-test-integration-server")]
+_FLIGHT_CLIENT_CMD = [
+ os.path.join(_EXE_PATH, "flight-test-integration-client"),
+ "-host",
+ "localhost",
+]
+
+
class CPPTester(Tester):
PRODUCER = True
CONSUMER = True
FLIGHT_SERVER = True
FLIGHT_CLIENT = True
- EXE_PATH = os.environ.get(
- 'ARROW_CPP_EXE_PATH',
- os.path.join(ARROW_ROOT_DEFAULT, 'cpp/build/debug'))
-
- CPP_INTEGRATION_EXE = os.path.join(EXE_PATH, 'arrow-json-integration-test')
- STREAM_TO_FILE = os.path.join(EXE_PATH, 'arrow-stream-to-file')
- FILE_TO_STREAM = os.path.join(EXE_PATH, 'arrow-file-to-stream')
-
- FLIGHT_SERVER_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-server')]
- FLIGHT_CLIENT_CMD = [
- os.path.join(EXE_PATH, 'flight-test-integration-client'),
- "-host", "localhost"]
-
- name = 'C++'
+ name = "C++"
- def _run(self, arrow_path=None, json_path=None, command='VALIDATE',
- quirks=None):
- cmd = [self.CPP_INTEGRATION_EXE, '--integration']
+ def _run(
+ self,
+ arrow_path=None,
+ json_path=None,
+ command="VALIDATE",
+ quirks=None
+ ):
Review comment:
quite a fight to get the linter happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12411: MINOR: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1037863905
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1047905983
Benchmark runs are scheduled for baseline = a061a921db02eec9f1e31acacdbdc6a1c96d5b67 and contender = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1. 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e0c9073711684888921e1c11094b0677...47a9f3ddb2e547e181e0f5c92572f935/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d1d207eb822b4d3684acf8c5e0c9e297...c6597e5a8b8f4ed392a27c60ab36b8a3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a143298a72d541bfa766a58633c6f2c0...9ca02c7c57f74129adcea8004eaf9e9b/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6022b36f6744468099867f9d7d5b4a27...a891d30f4cfc48ba830fe794b2e14da6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12411: ARROW-15698: [Integration] Privatized some code in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12411:
URL: https://github.com/apache/arrow/pull/12411#issuecomment-1047905983
Benchmark runs are scheduled for baseline = a061a921db02eec9f1e31acacdbdc6a1c96d5b67 and contender = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1. 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e0c9073711684888921e1c11094b0677...47a9f3ddb2e547e181e0f5c92572f935/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d1d207eb822b4d3684acf8c5e0c9e297...c6597e5a8b8f4ed392a27c60ab36b8a3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a143298a72d541bfa766a58633c6f2c0...9ca02c7c57f74129adcea8004eaf9e9b/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6022b36f6744468099867f9d7d5b4a27...a891d30f4cfc48ba830fe794b2e14da6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org