Re: svn commit: r1028778 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

[Servando Muñoz Garcia <sm...@gmail.com>]

----- Original Message ----- 
From: "Ruediger Pluem" <rp...@apache.org>
To: <de...@httpd.apache.org>
Sent: Sunday, October 31, 2010 10:45 AM
Subject: Re: svn commit: r1028778 - in /httpd/httpd/trunk: CHANGES 
docs/manual/mod/mod_rewrite.xml docs/manual/rewrite/flags.xml 
modules/mappers/mod_rewrite.c


>
>
> On 10/29/2010 10:19 PM, Eric Covener wrote:
>>>>> +            if (p->flags & RULEFLAG_END) {
>>>>> +                rewritelog((r, 8, perdir, "Rule has END flag, no 
>>>>> further rewriting for this request"));
>>>>> +                apr_pool_userdata_set("1", really_last_key, 
>>>>> apr_pool_cleanup_null, r->pool);
>>>> Why not using r->notes?
>>> Whoops, I saw it was a new table but missed that it was overlayed --  
>>> thanks
>>
>> Actually that overlay is not in internal_internal_redirect()  and
>> r->notes is not inherited/shared -- did you mean to look up to
>> r->main->notes or something like that?
>>
>
> I guess this could be fetched in the same way as saved_rulestatus (which 
> use simply r->notes).
> But maybe this is only for the case where you apply virtual host rules 
> first and (do not want) directory
> rules afterwards or do an ap_internal_fast_redirect?
> I think I am currently confused.
>
> Regards
>
> Rüdiger