You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/11/05 00:25:01 UTC

[kudu-CR] log: coalesce SegmentAllocator class

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14628


Change subject: log: coalesce SegmentAllocator class
......................................................................

log: coalesce SegmentAllocator class

A previous patch introduced this class but separated it out, but kept
it scattered throughout log.cc for reviewability. This patch puts all
the methods closer together for readability.

There are no functional changes in this patch.

Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
---
M src/kudu/consensus/log.cc
1 file changed, 245 insertions(+), 245 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14628/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Gerrit-Change-Number: 14628
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] log: coalesce SegmentAllocator class

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14628 )

Change subject: log: coalesce SegmentAllocator class
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Gerrit-Change-Number: 14628
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Nov 2019 23:59:26 +0000
Gerrit-HasComments: No

[kudu-CR] log: coalesce SegmentAllocator class

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14628 )

Change subject: log: coalesce SegmentAllocator class
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Gerrit-Change-Number: 14628
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Nov 2019 09:18:38 +0000
Gerrit-HasComments: No

[kudu-CR] log: coalesce SegmentAllocator class

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14628 )

Change subject: log: coalesce SegmentAllocator class
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Gerrit-Change-Number: 14628
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Nov 2019 16:44:33 +0000
Gerrit-HasComments: No

[kudu-CR] log: coalesce SegmentAllocator class

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14628 )

Change subject: log: coalesce SegmentAllocator class
......................................................................

log: coalesce SegmentAllocator class

A previous patch introduced this class but separated it out, but kept
it scattered throughout log.cc for reviewability. This patch puts all
the methods closer together for readability.

There are no functional changes in this patch.

Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Reviewed-on: http://gerrit.cloudera.org:8080/14628
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 253 insertions(+), 253 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Gerrit-Change-Number: 14628
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] log: coalesce SegmentAllocator class

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14628

to look at the new patch set (#2).

Change subject: log: coalesce SegmentAllocator class
......................................................................

log: coalesce SegmentAllocator class

A previous patch introduced this class but separated it out, but kept
it scattered throughout log.cc for reviewability. This patch puts all
the methods closer together for readability.

There are no functional changes in this patch.

Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 253 insertions(+), 253 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14628/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61d898025c41ab00443eaad05c0b805e668e5095
Gerrit-Change-Number: 14628
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)