[GitHub] [pinot] etolbakov commented on a diff in pull request #10032: fix: add AES256 server side encryption support for S3PinotFS

[GitBox <gi...@apache.org>]

etolbakov commented on code in PR #10032:
URL: https://github.com/apache/pinot/pull/10032#discussion_r1056940047


##########
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java:
##########
@@ -642,6 +654,12 @@ private CopyObjectRequest generateCopyObjectRequest(String copySource, URI dest,
       if (_ssekmsEncryptionContext != null) {
         copyReqBuilder.ssekmsEncryptionContext(_ssekmsEncryptionContext);
       }
+      if (_sseCustomerKey != null) {
+        copyReqBuilder
+            .sseCustomerAlgorithm(_sseCustomerAlgorithm)
+            .sseCustomerKey(_sseCustomerKey)
+            .sseCustomerKeyMD5(_sseCustomerKeyMD5);
+      }
     }
     return copyReqBuilder.build();
   }

Review Comment:
   Not in the scope of this functionality, but in the `open` method the caught exception is imminently re-thrown. The method could be simplified by removing `try-catch` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org