You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Hyunsik Choi (JIRA)" <ji...@apache.org> on 2009/10/29 17:50:59 UTC
[jira] Created: (HBASE-1941) Put's copy feature has a bug.
Put's copy feature has a bug.
-----------------------------
Key: HBASE-1941
URL: https://issues.apache.org/jira/browse/HBASE-1941
Project: Hadoop HBase
Issue Type: Bug
Components: client
Affects Versions: 0.20.1
Reporter: Hyunsik Choi
Put's copy feature has a bug. The copy does not consider the timestamp value.
In the following example, a put and its copied put prints out different timestamps.
{{
Put put = new Put("abc".getBytes());
put.setTimeStamp(1);
System.out.println(put.getTimeStamp());
Put put2 = new Put(put);
System.out.println(put2.getTimeStamp());
---------------------------
Above source code results in as follows:
1
9223372036854775807
}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HBASE-1941) Put's copy feature has a bug.
Posted by stack <st...@duboce.net>.
A "...separate patch that doesn't introduce incompatibility .." for 0.20
branch sounds like a good idea.
St.Ack
On Thu, Oct 29, 2009 at 11:11 AM, Dave Latham (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771528#action_12771528]
>
> Dave Latham commented on HBASE-1941:
> ------------------------------------
>
> See https://issues.apache.org/jira/browse/HBASE-1930 for some related
> discussion.
>
> It doesn't actually affect TableOutputFormat because the timestamp in Put
> only affects values added after it is set, and TableOutputFormat does not
> add any values to the Put object.
>
> HBASE-1930 fixed this for trunk, but perhaps a separate patch that doesn't
> introduce incompatibility would be good for the 0.20 branch.
>
> > Put's copy feature has a bug.
> > -----------------------------
> >
> > Key: HBASE-1941
> > URL: https://issues.apache.org/jira/browse/HBASE-1941
> > Project: Hadoop HBase
> > Issue Type: Bug
> > Components: client
> > Affects Versions: 0.20.1
> > Reporter: Hyunsik Choi
> >
> > Put's copy feature has a bug. The copy does not consider the timestamp
> value.
> > In the following example, a put and its copied put prints out different
> timestamps.
> > {quote}
> > Put put = new Put("abc".getBytes());
> > put.setTimeStamp(1);
> > System.out.println(put.getTimeStamp());
> > Put put2 = new Put(put);
> > System.out.println(put2.getTimeStamp());
> > ---------------------------
> > Above source code results in as follows:
> > 1
> > 9223372036854775807
> > {quote}
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (HBASE-1941) Put's copy feature has a bug.
Posted by "Dave Latham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771528#action_12771528 ]
Dave Latham commented on HBASE-1941:
------------------------------------
See https://issues.apache.org/jira/browse/HBASE-1930 for some related discussion.
It doesn't actually affect TableOutputFormat because the timestamp in Put only affects values added after it is set, and TableOutputFormat does not add any values to the Put object.
HBASE-1930 fixed this for trunk, but perhaps a separate patch that doesn't introduce incompatibility would be good for the 0.20 branch.
> Put's copy feature has a bug.
> -----------------------------
>
> Key: HBASE-1941
> URL: https://issues.apache.org/jira/browse/HBASE-1941
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.1
> Reporter: Hyunsik Choi
>
> Put's copy feature has a bug. The copy does not consider the timestamp value.
> In the following example, a put and its copied put prints out different timestamps.
> {quote}
> Put put = new Put("abc".getBytes());
> put.setTimeStamp(1);
> System.out.println(put.getTimeStamp());
> Put put2 = new Put(put);
> System.out.println(put2.getTimeStamp());
> ---------------------------
> Above source code results in as follows:
> 1
> 9223372036854775807
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1941) Put's copy feature has a bug.
Posted by "Dave Latham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Latham updated HBASE-1941:
-------------------------------
Status: Patch Available (was: Open)
> Put's copy feature has a bug.
> -----------------------------
>
> Key: HBASE-1941
> URL: https://issues.apache.org/jira/browse/HBASE-1941
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.1
> Reporter: Hyunsik Choi
> Attachments: 1941-branch0.20.patch
>
>
> Put's copy feature has a bug. The copy does not consider the timestamp value.
> In the following example, a put and its copied put prints out different timestamps.
> {quote}
> Put put = new Put("abc".getBytes());
> put.setTimeStamp(1);
> System.out.println(put.getTimeStamp());
> Put put2 = new Put(put);
> System.out.println(put2.getTimeStamp());
> ---------------------------
> Above source code results in as follows:
> 1
> 9223372036854775807
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1941) Put's copy feature has a bug.
Posted by "Dave Latham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Latham updated HBASE-1941:
-------------------------------
Attachment: 1941-branch0.20.patch
Patch for 0.20 branch updates the Put copy constructor to copy timestamp and writeToWAL. Also adds a warning to the setTimeStamp javadoc to make its behavior more clear.
> Put's copy feature has a bug.
> -----------------------------
>
> Key: HBASE-1941
> URL: https://issues.apache.org/jira/browse/HBASE-1941
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.1
> Reporter: Hyunsik Choi
> Attachments: 1941-branch0.20.patch
>
>
> Put's copy feature has a bug. The copy does not consider the timestamp value.
> In the following example, a put and its copied put prints out different timestamps.
> {quote}
> Put put = new Put("abc".getBytes());
> put.setTimeStamp(1);
> System.out.println(put.getTimeStamp());
> Put put2 = new Put(put);
> System.out.println(put2.getTimeStamp());
> ---------------------------
> Above source code results in as follows:
> 1
> 9223372036854775807
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1941) Put's copy feature has a bug.
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyunsik Choi updated HBASE-1941:
--------------------------------
Description:
Put's copy feature has a bug. The copy does not consider the timestamp value.
In the following example, a put and its copied put prints out different timestamps.
{quote}
Put put = new Put("abc".getBytes());
put.setTimeStamp(1);
System.out.println(put.getTimeStamp());
Put put2 = new Put(put);
System.out.println(put2.getTimeStamp());
---------------------------
Above source code results in as follows:
1
9223372036854775807
{quote}
was:
Put's copy feature has a bug. The copy does not consider the timestamp value.
In the following example, a put and its copied put prints out different timestamps.
{{
Put put = new Put("abc".getBytes());
put.setTimeStamp(1);
System.out.println(put.getTimeStamp());
Put put2 = new Put(put);
System.out.println(put2.getTimeStamp());
---------------------------
Above source code results in as follows:
1
9223372036854775807
}}
> Put's copy feature has a bug.
> -----------------------------
>
> Key: HBASE-1941
> URL: https://issues.apache.org/jira/browse/HBASE-1941
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.1
> Reporter: Hyunsik Choi
>
> Put's copy feature has a bug. The copy does not consider the timestamp value.
> In the following example, a put and its copied put prints out different timestamps.
> {quote}
> Put put = new Put("abc".getBytes());
> put.setTimeStamp(1);
> System.out.println(put.getTimeStamp());
> Put put2 = new Put(put);
> System.out.println(put2.getTimeStamp());
> ---------------------------
> Above source code results in as follows:
> 1
> 9223372036854775807
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1941) Put's copy feature has a bug.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1941:
-------------------------
Resolution: Fixed
Fix Version/s: 0.20.2
Status: Resolved (was: Patch Available)
Committed. Thanks for patch Dave.
> Put's copy feature has a bug.
> -----------------------------
>
> Key: HBASE-1941
> URL: https://issues.apache.org/jira/browse/HBASE-1941
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.1
> Reporter: Hyunsik Choi
> Fix For: 0.20.2
>
> Attachments: 1941-branch0.20.patch
>
>
> Put's copy feature has a bug. The copy does not consider the timestamp value.
> In the following example, a put and its copied put prints out different timestamps.
> {quote}
> Put put = new Put("abc".getBytes());
> put.setTimeStamp(1);
> System.out.println(put.getTimeStamp());
> Put put2 = new Put(put);
> System.out.println(put2.getTimeStamp());
> ---------------------------
> Above source code results in as follows:
> 1
> 9223372036854775807
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1941) Put's copy feature has a bug.
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771476#action_12771476 ]
Hyunsik Choi commented on HBASE-1941:
-------------------------------------
Consequently, this bug affects TableOutputFormat.class.
> Put's copy feature has a bug.
> -----------------------------
>
> Key: HBASE-1941
> URL: https://issues.apache.org/jira/browse/HBASE-1941
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.1
> Reporter: Hyunsik Choi
>
> Put's copy feature has a bug. The copy does not consider the timestamp value.
> In the following example, a put and its copied put prints out different timestamps.
> {quote}
> Put put = new Put("abc".getBytes());
> put.setTimeStamp(1);
> System.out.println(put.getTimeStamp());
> Put put2 = new Put(put);
> System.out.println(put2.getTimeStamp());
> ---------------------------
> Above source code results in as follows:
> 1
> 9223372036854775807
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.