You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 18:01:46 UTC
[GitHub] [airflow] potiuk opened a new pull request #12990: Changes release image preparation to use PyPI packages
potiuk opened a new pull request #12990:
URL: https://github.com/apache/airflow/pull/12990
Since we released all teh provider packages to PyPI now in
RC version, we can now change the mechanism to prepare the
production to use released packages in case of tagged builds.
The "branch" production images are still prepared using the
CI images and .whl packages built from sources, but the
release packages are built from officially released PyPI
packages.
Also some corrections and updates were made to the release process:
* the constraint tags when RC candidate is sent should contain
rcn suffix.
* there was missing step about pushing the release tag once the
release is out
* pushing tag to GitHub should be done after the PyPI packages
are uploaded, so that automated image building in DockerHub
can use those packages.
* added a note that in case we will release some provider
packages that depend on the just released airflow version
they shoudl be released after airflow is in PyPI but before
the tag is pushed to GitHub (also to allow the image to be
build automatically from the released packages)
Fixes: #12970
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-742747309
I tested it all, added a few fixes and it's ready to go. I used it now to rebuild and re-push all the rc prod images and it looks good.
```
airflow@d88cc6f8dcc9:/opt/airflow$ airflow version
2.0.0rc1
airflow@d88cc6f8dcc9:/opt/airflow$ airflow providers list
package_name | description | version
=========================================+==============================================================================================+=========
apache-airflow-providers-amazon | Amazon integration (including Amazon Web Services (AWS) https://aws.amazon.com/) | 1.0.0rc1
apache-airflow-providers-celery | Celery http://www.celeryproject.org/ | 1.0.0rc1
apache-airflow-providers-cncf-kubernetes | Kubernetes https://kubernetes.io/ | 1.0.0rc1
apache-airflow-providers-docker | Docker https://docs.docker.com/install/ | 1.0.0rc1
apache-airflow-providers-elasticsearch | Elasticsearch https://https//www.elastic.co/elasticsearch | 1.0.0rc1
apache-airflow-providers-ftp | File Transfer Protocol (FTP) https://tools.ietf.org/html/rfc114 | 1.0.0rc1
apache-airflow-providers-google | Google services including: | 1.0.0rc1
| |
| - Google Ads https://ads.google.com/ |
| - Google Cloud (GCP) https://cloud.google.com/ |
| - Google Firebase https://firebase.google.com/ |
| - Google Marketing Platform https://marketingplatform.google.com/ |
| - Google Workspace https://workspace.google.pl/ (formerly Google Suite) |
apache-airflow-providers-grpc | gRPC https://grpc.io/ | 1.0.0rc1
apache-airflow-providers-hashicorp | Hashicorp including Hashicorp Vault https://www.vaultproject.io/ | 1.0.0rc1
apache-airflow-providers-http | Hypertext Transfer Protocol (HTTP) https://www.w3.org/Protocols/ | 1.0.0rc1
apache-airflow-providers-imap | Internet Message Access Protocol (IMAP) https://tools.ietf.org/html/rfc3501 | 1.0.0rc1
apache-airflow-providers-microsoft-azure | Microsoft Azure https://azure.microsoft.com/ | 1.0.0rc1
apache-airflow-providers-mysql | MySQL https://www.mysql.com/products/ | 1.0.0rc1
apache-airflow-providers-postgres | PostgreSQL https://www.postgresql.org/ | 1.0.0rc1
apache-airflow-providers-redis | Redis https://redis.io/ | 1.0.0rc1
apache-airflow-providers-sendgrid | Sendgrid https://sendgrid.com/ | 1.0.0rc1
apache-airflow-providers-sftp | SSH File Transfer Protocol (SFTP) https://tools.ietf.org/wg/secsh/draft-ietf-secsh-filexfer/ | 1.0.0rc1
apache-airflow-providers-slack | Slack https://slack.com/ | 1.0.0rc1
apache-airflow-providers-sqlite | SQLite https://www.sqlite.org/ | 1.0.0rc1
apache-airflow-providers-ssh | Secure Shell (SSH) https://tools.ietf.org/html/rfc4251 | 1.0.0rc1
airflow@d88cc6f8dcc9:/opt/airflow$ pip freeze | grep airflow
apache-airflow==2.0.0rc1
apache-airflow-providers-amazon==1.0.0rc1
apache-airflow-providers-celery==1.0.0rc1
apache-airflow-providers-cncf-kubernetes==1.0.0rc1
apache-airflow-providers-docker==1.0.0rc1
apache-airflow-providers-elasticsearch==1.0.0rc1
apache-airflow-providers-ftp==1.0.0rc1
apache-airflow-providers-google==1.0.0rc1
apache-airflow-providers-grpc==1.0.0rc1
apache-airflow-providers-hashicorp==1.0.0rc1
apache-airflow-providers-http==1.0.0rc1
apache-airflow-providers-imap==1.0.0rc1
apache-airflow-providers-microsoft-azure==1.0.0rc1
apache-airflow-providers-mysql==1.0.0rc1
apache-airflow-providers-postgres==1.0.0rc1
apache-airflow-providers-redis==1.0.0rc1
apache-airflow-providers-sendgrid==1.0.0rc1
apache-airflow-providers-sftp==1.0.0rc1
apache-airflow-providers-slack==1.0.0rc1
apache-airflow-providers-sqlite==1.0.0rc1
apache-airflow-providers-ssh==1.0.0rc1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-743172230
@ashb @kaxil -> I updated this PR a little - i clarified some of the docs/parameters and added some more clarifying comments in the Dockerfile. I also changed the default values in the way than when you just run the `docker build .` you will get the "true" production build - build from PyPI packages and not from the sources.
This is the final step of making the "Production image" true production-ready and once 2.0 is out, it makes it suitable now to make it into the "Docker official image".
Once we release 2.0 I will complete the work on that:
#11740 -> separate read-only repo with only the image and scripts so that you can build the image without Airflow sources.
#10107 -> apply for the "official docker image" status with that repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-742695912
I am testing this still, but might be good that you start reviewing it @ashb @kaxil. Once I do and we merge it, we should cherry-pick that one to v2-0-test and we can remove the 'Updates providers versions to 1.0.0 (#12955)' as discussed in https://apache-airflow.slack.com/archives/CCPRP7943/p1607617162178600?thread_ts=1607596760.166600&cid=CCPRP7943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-743732466
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12990:
URL: https://github.com/apache/airflow/pull/12990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541095323
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -608,59 +610,33 @@ production image. There are three types of build:
* You can build the image from released PyPi airflow package (used to build the official Docker image)
* You can build the image from any version in GitHub repository(this is used mostly for system testing).
-+-----------------------------------+-----------------------------------+
-| Build argument | What to specify |
-+===================================+===================================+
-| ``AIRFLOW_INSTALL_SOURCES`` | Should point to the sources of |
-| | of Apache Airflow. It can be |
-| | either "." for installation from |
-| | local sources, "apache-airflow" |
-| | for installation from packages |
-| | and URL to installation from |
-| | GitHub repository (see below) |
-| | to install from any GitHub |
-| | version |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_INSTALL_VERSION`` | Optional - might be used for |
-| | package installation case to |
-| | set Airflow version for example |
-| | "==1.10.14". Remember to also |
-| | Set ``AIRFLOW_VERSION`` |
-| | when you use it. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_CONSTRAINTS_REFERENCE`` | reference (branch or tag) from |
-| | GitHub where constraints file |
-| | is taken from. By default it is |
-| | ``constraints-master`` but can be |
-| | ``constraints-1-10`` for 1.10.* |
-| | constraint or if you want to |
-| | point to specific version |
-| | might be ``constraints-1.10.14`` |
-+-----------------------------------+-----------------------------------+
-| ``SLUGIFY_USES_TEXT_UNIDECODE`` | In case of of installing airflow |
-| | 1.10.2 or 1.10.1 you need to |
-| | set this arg to ``yes``. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_WWW`` | In case of Airflow 2.0 it should |
-| | be "www", in case of Airflow 1.10 |
-| | series it should be "www_rbac". |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_FROM`` | Sources of Airflow. Set it to |
-| | "empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_TO`` | Target for Airflow sources. Set |
-| | to "/empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-
++-----------------------------------+------------------------+-----------------------------------------------------------------------------------+
+| Build argument | Default | What to specify |
++===================================+========================+===================================================================================+
+| ``AIRFLOW_INSTALLATION_MEDIA`` | ``apache-airflow`` | Should point to the installation media of Apache Airflow. It can "apache-airflow" |
Review comment:
Oh yeah ``AIRFLOW_INSTALLATION_METHOD`` is MUCH better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541095286
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -608,59 +610,33 @@ production image. There are three types of build:
* You can build the image from released PyPi airflow package (used to build the official Docker image)
* You can build the image from any version in GitHub repository(this is used mostly for system testing).
-+-----------------------------------+-----------------------------------+
-| Build argument | What to specify |
-+===================================+===================================+
-| ``AIRFLOW_INSTALL_SOURCES`` | Should point to the sources of |
-| | of Apache Airflow. It can be |
-| | either "." for installation from |
-| | local sources, "apache-airflow" |
-| | for installation from packages |
-| | and URL to installation from |
-| | GitHub repository (see below) |
-| | to install from any GitHub |
-| | version |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_INSTALL_VERSION`` | Optional - might be used for |
-| | package installation case to |
-| | set Airflow version for example |
-| | "==1.10.14". Remember to also |
-| | Set ``AIRFLOW_VERSION`` |
-| | when you use it. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_CONSTRAINTS_REFERENCE`` | reference (branch or tag) from |
-| | GitHub where constraints file |
-| | is taken from. By default it is |
-| | ``constraints-master`` but can be |
-| | ``constraints-1-10`` for 1.10.* |
-| | constraint or if you want to |
-| | point to specific version |
-| | might be ``constraints-1.10.14`` |
-+-----------------------------------+-----------------------------------+
-| ``SLUGIFY_USES_TEXT_UNIDECODE`` | In case of of installing airflow |
-| | 1.10.2 or 1.10.1 you need to |
-| | set this arg to ``yes``. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_WWW`` | In case of Airflow 2.0 it should |
-| | be "www", in case of Airflow 1.10 |
-| | series it should be "www_rbac". |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_FROM`` | Sources of Airflow. Set it to |
-| | "empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_TO`` | Target for Airflow sources. Set |
-| | to "/empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-
++-----------------------------------+------------------------+-----------------------------------------------------------------------------------+
+| Build argument | Default | What to specify |
++===================================+========================+===================================================================================+
+| ``AIRFLOW_INSTALLATION_MEDIA`` | ``apache-airflow`` | Should point to the installation media of Apache Airflow. It can "apache-airflow" |
Review comment:
yeah that sounds better I think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-743213789
I think it should be good to go @kaxil @ashb. the only failing test is quarantine I believe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-743152980
[The Workflow run](https://github.com/apache/airflow/actions/runs/415332870) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-743245318
No time to review before Monday most likely, if someone else can review sooner :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541091759
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -608,59 +610,33 @@ production image. There are three types of build:
* You can build the image from released PyPi airflow package (used to build the official Docker image)
* You can build the image from any version in GitHub repository(this is used mostly for system testing).
-+-----------------------------------+-----------------------------------+
-| Build argument | What to specify |
-+===================================+===================================+
-| ``AIRFLOW_INSTALL_SOURCES`` | Should point to the sources of |
-| | of Apache Airflow. It can be |
-| | either "." for installation from |
-| | local sources, "apache-airflow" |
-| | for installation from packages |
-| | and URL to installation from |
-| | GitHub repository (see below) |
-| | to install from any GitHub |
-| | version |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_INSTALL_VERSION`` | Optional - might be used for |
-| | package installation case to |
-| | set Airflow version for example |
-| | "==1.10.14". Remember to also |
-| | Set ``AIRFLOW_VERSION`` |
-| | when you use it. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_CONSTRAINTS_REFERENCE`` | reference (branch or tag) from |
-| | GitHub where constraints file |
-| | is taken from. By default it is |
-| | ``constraints-master`` but can be |
-| | ``constraints-1-10`` for 1.10.* |
-| | constraint or if you want to |
-| | point to specific version |
-| | might be ``constraints-1.10.14`` |
-+-----------------------------------+-----------------------------------+
-| ``SLUGIFY_USES_TEXT_UNIDECODE`` | In case of of installing airflow |
-| | 1.10.2 or 1.10.1 you need to |
-| | set this arg to ``yes``. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_WWW`` | In case of Airflow 2.0 it should |
-| | be "www", in case of Airflow 1.10 |
-| | series it should be "www_rbac". |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_FROM`` | Sources of Airflow. Set it to |
-| | "empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_TO`` | Target for Airflow sources. Set |
-| | to "/empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-
++-----------------------------------+------------------------+-----------------------------------------------------------------------------------+
+| Build argument | Default | What to specify |
++===================================+========================+===================================================================================+
+| ``AIRFLOW_INSTALLATION_MEDIA`` | ``apache-airflow`` | Should point to the installation media of Apache Airflow. It can "apache-airflow" |
Review comment:
Yeah. Thought about it and could not come with a better name so far. I had "AIRFLOW_INSTALLATION_SOURCE" before but it was misleading as well.
How about ``AIRFLOW_INSTALLATION_METHOD`` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-742758220
And small update for test vs. stable for pre-installed packages. We will have less problems if v2-0-test diverges to0 much for a while from v2-0-stable (hopefully NOT too much).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541541137
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -552,6 +599,59 @@ At this point we release an official package:
- Update CHANGELOG.md with the details, and commit it.
+- Re-Tag & Push the constraints files with the final release version.
+
+ ```shell script
+ git checkout constraints-${RC}
+ git tag -s "constraints-${VERSION}"
+ git push origin "constraints-${VERSION}"
+ ```
+
+- Push Tag for the final version
+
+This step should only be done now and not before, because it triggers an automated build of
+the production docker image, using the packages that are currently released in PyPI
+(both airflow and latest provider packages).
+
+```shell script
+git push origin ${VERSION}
+```
Review comment:
```suggestion
This step should only be done now and not before, because it triggers an automated build of
the production docker image, using the packages that are currently released in PyPI
(both airflow and latest provider packages).
```shell script
git push origin ${VERSION}
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#issuecomment-743213789
I think it should be good to go @kaxil @ashb. the only failing test is quarantine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541090036
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -608,59 +610,33 @@ production image. There are three types of build:
* You can build the image from released PyPi airflow package (used to build the official Docker image)
* You can build the image from any version in GitHub repository(this is used mostly for system testing).
-+-----------------------------------+-----------------------------------+
-| Build argument | What to specify |
-+===================================+===================================+
-| ``AIRFLOW_INSTALL_SOURCES`` | Should point to the sources of |
-| | of Apache Airflow. It can be |
-| | either "." for installation from |
-| | local sources, "apache-airflow" |
-| | for installation from packages |
-| | and URL to installation from |
-| | GitHub repository (see below) |
-| | to install from any GitHub |
-| | version |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_INSTALL_VERSION`` | Optional - might be used for |
-| | package installation case to |
-| | set Airflow version for example |
-| | "==1.10.14". Remember to also |
-| | Set ``AIRFLOW_VERSION`` |
-| | when you use it. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_CONSTRAINTS_REFERENCE`` | reference (branch or tag) from |
-| | GitHub where constraints file |
-| | is taken from. By default it is |
-| | ``constraints-master`` but can be |
-| | ``constraints-1-10`` for 1.10.* |
-| | constraint or if you want to |
-| | point to specific version |
-| | might be ``constraints-1.10.14`` |
-+-----------------------------------+-----------------------------------+
-| ``SLUGIFY_USES_TEXT_UNIDECODE`` | In case of of installing airflow |
-| | 1.10.2 or 1.10.1 you need to |
-| | set this arg to ``yes``. |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_WWW`` | In case of Airflow 2.0 it should |
-| | be "www", in case of Airflow 1.10 |
-| | series it should be "www_rbac". |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_FROM`` | Sources of Airflow. Set it to |
-| | "empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-| ``AIRFLOW_SOURCES_TO`` | Target for Airflow sources. Set |
-| | to "/empty" to avoid costly |
-| | Docker context copying |
-| | in case of installation from |
-| | the package or from GitHub URL. |
-| | See examples below |
-+-----------------------------------+-----------------------------------+
-
++-----------------------------------+------------------------+-----------------------------------------------------------------------------------+
+| Build argument | Default | What to specify |
++===================================+========================+===================================================================================+
+| ``AIRFLOW_INSTALLATION_MEDIA`` | ``apache-airflow`` | Should point to the installation media of Apache Airflow. It can "apache-airflow" |
Review comment:
All looks good, except the name of this var `AIRFLOW_INSTALLATION_MEDIA` , should we `AIRFLOW_PACKAGE` / `AIRFLOW_COMPONENT` or any other suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12990: Changes release image preparation to use PyPI packages
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12990:
URL: https://github.com/apache/airflow/pull/12990#discussion_r541540844
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -182,6 +183,51 @@ https://pypi.python.org/pypi/apache-airflow
It is important to stress that this snapshot should not be named "release", and it
is not supposed to be used by and advertised to the end-users who do not read the devlist.
+- Push Tag for the release candidate
+
+This step should only be done now and not before, because it triggers an automated build of
+the production docker image, using the packages that are currently released in PyPI
+(both airflow and latest provider packages).
+
+```shell script
+git push origin ${VERSION}
+```
Review comment:
```suggestion
This step should only be done now and not before, because it triggers an automated build of
the production docker image, using the packages that are currently released in PyPI
(both airflow and latest provider packages).
```shell script
git push origin ${VERSION}
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org