You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Dennis Waldherr (Jira)" <ji...@apache.org> on 2019/12/19 11:08:00 UTC
[jira] [Updated] (WICKET-6720)
ConcatBundleResource#getResourceStream should not eagerly fetch resources
[ https://issues.apache.org/jira/browse/WICKET-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Waldherr updated WICKET-6720:
------------------------------------
Priority: Minor (was: Major)
> ConcatBundleResource#getResourceStream should not eagerly fetch resources
> -------------------------------------------------------------------------
>
> Key: WICKET-6720
> URL: https://issues.apache.org/jira/browse/WICKET-6720
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 8.5.0
> Reporter: Dennis Waldherr
> Priority: Minor
>
> If {{ConcatBundleResource}} is used in conjunction with {{LastModifiedResourceVersion}}, it will concatenate its resources for every request, even if unchanged.
> The reason for this is, that {{LastModifiedResourceVersion#getVersion}} uses only {{lastModified}} of the {{getResourceStream}} call to determine a version. But {{getResourceStream}} of {{ConcatBundleResource}} collects (and compresses) for that call already.
> This effectively cancels out any time saved by using the class in the first place.
> It should only collect and build the actual content "on demand".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)