You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/30 04:37:58 UTC
[GitHub] [hbase] saintstack opened a new pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack opened a new pull request #3105:
URL: https://github.com/apache/hbase/pull/3105
First extract an hbase-coprocessor module used by hbase-client, hbase-server.
This is prerequisite to extracting an hbase-wal module.
M hbase-common/src/main/java/org/apache/hadoop/hbase/Abortable.java
M hbase-common/src/main/java/org/apache/hadoop/hbase/DoNotRetryIOException.java
M hbase-common/src/main/java/org/apache/hadoop/hbase/util/SortedList.java
Move to hbase-common. Its a generic Interface. Need by
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/Coprocessor.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEnvironment.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/CoreCoprocessor.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContext.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
M hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ReadOnlyConfiguration.java
Move to hbase-coprocessor.
M hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
M hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/DoubleColumnInterpreter.java
M hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java
M hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java
Moved to hbase-endpoint where they are used.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
Include region name when toString'd.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
Include WAL name when toString'd.
M hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
Add utility used in testing here from CoprocessorHost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811170552
Thanks for taking a look @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-809932562
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 10s | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 11s | branch-2 passed |
| +1 :green_heart: | compile | 2m 59s | branch-2 passed |
| +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 43s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 10s | the patch passed |
| +1 :green_heart: | compile | 2m 30s | the patch passed |
| +1 :green_heart: | javac | 2m 29s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 31m 51s | root in the patch failed. |
| | | 75m 45s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3105 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7417e3de910a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa8b9659b1 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/testReport/ |
| Max. process+thread count | 616 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-coprocessor . hbase-client hbase-endpoint hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811532316
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 40s | branch-2 passed |
| +1 :green_heart: | compile | 2m 16s | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 2s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 38s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 55s | root in the patch failed. |
| -1 :x: | compile | 0m 46s | root in the patch failed. |
| -0 :warning: | javac | 0m 46s | root in the patch failed. |
| -1 :x: | shadedjars | 2m 52s | patch has 42 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 46s | root in the patch failed. |
| -0 :warning: | javadoc | 0m 9s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 9s | hbase-server in the patch failed. |
| -0 :warning: | javadoc | 0m 13s | hbase-wal generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) |
||| _ Other Tests _ |
| -1 :x: | unit | 3m 49s | root in the patch failed. |
| | | 31m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3105 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 81c5066c8275 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 1d3ea38f1e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-wal.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/testReport/ |
| Max. process+thread count | 659 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-coprocessor hbase-hadoop-compat hbase-hadoop2-compat . hbase-client hbase-endpoint hbase-mapreduce hbase-server hbase-wal U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-809925790
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 12s | branch-2 passed |
| +1 :green_heart: | compile | 2m 46s | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 52s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 33s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 59s | the patch passed |
| +1 :green_heart: | compile | 2m 49s | the patch passed |
| +1 :green_heart: | javac | 2m 49s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 59s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 25s | hbase-common in the patch passed. |
| -0 :warning: | javadoc | 0m 16s | hbase-coprocessor generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -0 :warning: | javadoc | 2m 50s | root generated 2 new + 186 unchanged - 2 fixed = 188 total (was 188) |
| +1 :green_heart: | javadoc | 0m 28s | hbase-client generated 0 new + 90 unchanged - 2 fixed = 90 total (was 92) |
| +1 :green_heart: | javadoc | 0m 13s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | javadoc | 0m 41s | hbase-server in the patch passed. |
||| _ Other Tests _ |
| -1 :x: | unit | 18m 35s | root in the patch failed. |
| | | 59m 30s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3105 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 55e4900b0cae 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa8b9659b1 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-coprocessor.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/testReport/ |
| Max. process+thread count | 937 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-coprocessor . hbase-client hbase-endpoint hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811166582
@Apache9 Hey. Here is what I wrote in the JIRA description: "Extract an hbase-wal module upon which hbase-server can depend; makes hbase-server smaller and maybe we could do an hbase-wal standalone... This is an experiment." I'm trying to see how far I can get extracting WAL from hbase-server. So far, it looks like I need to pull out the basic hbase-coprocessor classes too into their own module. Was trying to shrink hbase-server size. Also trying to make WAL more distinct such that it could live apart from the rest of HBase.
At least the basic classes and Interfaces can be extracted. Will see how much further I can get. Thanks for taking a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r605013678
##########
File path: hbase-client/pom.xml
##########
@@ -72,6 +72,10 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
I'll be back here. Its an odd one. We depend on hbase-wal in hbase-client JUST because of FailedLogCloseException... I'll probably undo this dependency in a later version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811539332
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 46s | branch-2 passed |
| +1 :green_heart: | compile | 9m 13s | branch-2 passed |
| +1 :green_heart: | checkstyle | 2m 34s | branch-2 passed |
| +1 :green_heart: | spotbugs | 15m 28s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 0s | root in the patch failed. |
| -1 :x: | compile | 2m 18s | root in the patch failed. |
| -0 :warning: | javac | 2m 18s | root in the patch failed. |
| -0 :warning: | checkstyle | 0m 29s | The patch fails to run checkstyle in root |
| -0 :warning: | whitespace | 0m 0s | The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. |
| -1 :x: | hadoopcheck | 1m 27s | The patch causes 42 errors with Hadoop v3.1.2. |
| -1 :x: | hadoopcheck | 2m 53s | The patch causes 42 errors with Hadoop v3.2.1. |
| -1 :x: | spotbugs | 0m 13s | hbase-wal in the patch failed. |
| -1 :x: | spotbugs | 3m 17s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | hbase-client in the patch failed. |
| -1 :x: | spotbugs | 0m 23s | hbase-mapreduce in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 31s | The patch does not generate ASF License warnings. |
| | | 53m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3105 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle |
| uname | Linux bf3d71a31f33 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 1d3ea38f1e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/whitespace-eol.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-javac-3.2.1.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-wal.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-mapreduce.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt |
| Max. process+thread count | 127 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-coprocessor hbase-hadoop-compat hbase-hadoop2-compat hbase-wal . hbase-client hbase-endpoint hbase-mapreduce hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r603840821
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
##########
@@ -90,6 +90,10 @@ public void shutdown() {
super.shutdown();
MetricsCoprocessor.removeRegistry(this.metricRegistry);
}
+
+ @Override public String toString() {
Review comment:
Is `toString()` also required for `WALCoprocessorHost`?
##########
File path: hbase-client/pom.xml
##########
@@ -72,6 +72,10 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
Hmm, it's not just server but client too can't live without it.
##########
File path: hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
##########
@@ -87,19 +89,5 @@ public boolean shouldBypass() {
return Optional.ofNullable(caller);
}
- /**
- * Instantiates a new ObserverContext instance if the passed reference is <code>null</code> and
- * sets the environment in the new or existing instance. This allows deferring the instantiation
- * of a ObserverContext until it is actually needed.
- * @param <E> The environment type for the context
- * @param env The coprocessor environment to set
- * @return An instance of <code>ObserverContext</code> with the environment set
- */
- @Deprecated
Review comment:
We are good to remove this in 2.x releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r605012266
##########
File path: hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
##########
@@ -87,19 +89,5 @@ public boolean shouldBypass() {
return Optional.ofNullable(caller);
}
- /**
- * Instantiates a new ObserverContext instance if the passed reference is <code>null</code> and
- * sets the environment in the new or existing instance. This allows deferring the instantiation
- * of a ObserverContext until it is actually needed.
- * @param <E> The environment type for the context
- * @param env The coprocessor environment to set
- * @return An instance of <code>ObserverContext</code> with the environment set
- */
- @Deprecated
Review comment:
Sorry for confusion @virajjasani ... This exploratory work is against branch-2 but target is master branch. We cannot remove these methods as you suggest in branch-2 but we could in master. Odd is that these methods are deprecated but without an alternative.... I need to provide something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-810858972
Mind explain the plan first?
I guess the problem here is that the WAL implementation may depend on some HRegion stuff, and yes coprocessor could be a problem if in the implementation we need to call something like CoprocessorHost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r605054619
##########
File path: hbase-client/pom.xml
##########
@@ -72,6 +72,10 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
> We depend on hbase-wal in hbase-client JUST because of FailedLogCloseException... I'll probably undo this dependency in a later version.
Oh, that's better than expected. Good to know.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack closed pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack closed pull request #3105:
URL: https://github.com/apache/hbase/pull/3105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811522147
I wrote a note up in the JIRA. I don't this experiment is going to go any further. Will close it out as unable to break out enough of hbase-coprocessor to call the module hbase-coprocessor and ditto for hbase-wal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811167368
To clarify, I'm doing this exploratory work on a branch against branch-2 but when comes time to put up a branch, will do it against master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-809937292
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 20s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 55s | branch-2 passed |
| +1 :green_heart: | compile | 9m 16s | branch-2 passed |
| +1 :green_heart: | checkstyle | 2m 25s | branch-2 passed |
| +1 :green_heart: | spotbugs | 14m 4s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 43s | the patch passed |
| +1 :green_heart: | compile | 9m 14s | the patch passed |
| -0 :warning: | javac | 9m 14s | root generated 20 new + 1842 unchanged - 0 fixed = 1862 total (was 1842) |
| -0 :warning: | checkstyle | 2m 27s | root: The patch generated 8 new + 110 unchanged - 37 fixed = 118 total (was 147) |
| -0 :warning: | whitespace | 0m 0s | The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 12m 50s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 15m 34s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 8s | The patch does not generate ASF License warnings. |
| | | 86m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3105 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle |
| uname | Linux bb93276143f1 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa8b9659b1 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 126 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-coprocessor . hbase-client hbase-endpoint hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-811533565
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 4s | branch-2 passed |
| +1 :green_heart: | compile | 2m 44s | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 19s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 5s | root in the patch failed. |
| -1 :x: | compile | 0m 58s | root in the patch failed. |
| -0 :warning: | javac | 0m 58s | root in the patch failed. |
| -1 :x: | shadedjars | 3m 14s | patch has 42 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 23s | hbase-common generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -0 :warning: | javadoc | 0m 14s | hbase-coprocessor generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -0 :warning: | javadoc | 0m 13s | hbase-wal in the patch failed. |
| -0 :warning: | javadoc | 0m 49s | root in the patch failed. |
| -0 :warning: | javadoc | 0m 10s | hbase-client in the patch failed. |
| -0 :warning: | javadoc | 0m 10s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 3m 56s | root in the patch failed. |
| | | 35m 45s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3105 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b3a71ac2a8e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 1d3ea38f1e |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-coprocessor.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-wal.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/testReport/ |
| Max. process+thread count | 716 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-coprocessor hbase-hadoop-compat hbase-hadoop2-compat hbase-wal . hbase-client hbase-endpoint hbase-mapreduce hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3105/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#issuecomment-814434224
Failed project. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org