[GitHub] [spark] holdenk edited a comment on pull request #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

[GitBox <gi...@apache.org>]

holdenk edited a comment on pull request #26440:
URL: https://github.com/apache/spark/pull/26440#issuecomment-646387458


   > I haven't looked into the codes closely yet - I will try to read and follow more closely. I just noticed the discussions made in these PRs which are virtually from you.
   > 
   > My point is that:
   > 
   > * Here looks, to me, when we needed to call more review and explicit approvals given that this affects all other components in Spark.
   > * Seems the review comments are not fully addressed, but being merged. I see that PR #28370  was merged right away after leaving [#28370 (comment)](https://github.com/apache/spark/pull/28370#issuecomment-630363255).
   
   That was my LGTM I'm going to merge this comment so yeah that's sort of what I expect. If there was another engaged committer who had expressed interest here of course I'd wait a bit for them to sign off as well.
   > * It looks we needed to have a SPIP.
   
   I'm not sure I agree, but if you do feel free to bring it up on the dev@ list and I can refactor the design doc into an SPIP formatted one.
   > 
   > It looks to me that we're rushing on these PRs where actually we should be the most conservative.
   
   There is no plans to cut a release from master anytime soon, this isn't being back ported to branch-3, we've had multiple eyes on the design doc from various committers, it's disabled by default. The PR was open for multiple weeks (I've seen commiters merge commits larger than this with the PR being open for less than a day). I don't agree with you here, and if you still think I've been too hasty lets have the discussion on dev@ or private@ as appropriate.
   
   (edit: formatting)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org