[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2576: Bump Hudi 0.11.0

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #2576:
URL: https://github.com/apache/incubator-kyuubi/pull/2576#discussion_r867074800


##########
pom.xml:
##########
@@ -964,27 +964,6 @@
             </dependency>
 
             <!-- Hudi dependency  -->
-            <!--
-              We don't use hadoop-common directly, it's only for suppressing exception:
-                 Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (default) on project
-                 kyuubi-spark-sql-engine_2.12: Error creating shaded jar: Could not resolve following dependencies:
-                 [jdk.tools:jdk.tools:jar:1.6 (system)]
-
-              The issue only occurs on GitHub Action environment with Hudi 0.10.0 and JDK 11.
-              After few days digging, only found one place introduces jdk.tools,
-
-              - org.apache.hudi:hudi-common:jar:0.10.0:test
-                - org.apache.hbase:hbase-server:jar:1.2.3:test
-                  - org.apache.hadoop:hadoop-common:jar:2.5.1:test
-                    - org.apache.hadoop:hadoop-annotations:jar:2.5.1:test
-                      - jdk.tools:jdk.tools:jar:1.6:system
-            -->
-            <dependency>
-                <groupId>org.apache.hadoop</groupId>
-                <artifactId>hadoop-common</artifactId>

Review Comment:
   Hudi 0.11 has a different module dependency graph, the exclusion may need to update. 
   
   BTW, seems that Hudi 0.11 reduced the bundle jar dependencies, but I failed to pass the ut after switching to bundle jar w/ spark 3.2 in my previous try.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org