[GitHub] [flink] dianfu commented on a change in pull request #11220: [FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #11220: [FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams
URL: https://github.com/apache/flink/pull/11220#discussion_r384908071
 
 

 ##########
 File path: flink-python/setup.py
 ##########
 @@ -224,7 +224,7 @@ def remove_if_exists(file_path):
         author_email='dev@flink.apache.org',
         python_requires='>=3.5',
         install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0', 'apache-beam==2.19.0',
-                          'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1'],
+                          'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1', 'jsonpickle==1.2'],
 
 Review comment:
   What about make it an optional requirement such as following?
   `
   extras_require={
               'ml': ['jsonpickle==1.2']
   }
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services