You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/15 01:05:00 UTC
[jira] [Commented] (ORC-281) Fix InputStream.hh with override
markers on destructors
[ https://issues.apache.org/jira/browse/ORC-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291862#comment-16291862 ]
ASF GitHub Bot commented on ORC-281:
------------------------------------
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/203
ORC-281. Add missing override markers on destructors in InputStream.hh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-281
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit 4d297ea3ea112264037c3c2f747eb93b06b7a6c7
Author: Owen O'Malley <om...@apache.org>
Date: 2017-12-15T01:03:05Z
ORC-281. Add missing override markers on destructors in InputStream.hh
----
> Fix InputStream.hh with override markers on destructors
> -------------------------------------------------------
>
> Key: ORC-281
> URL: https://issues.apache.org/jira/browse/ORC-281
> Project: ORC
> Issue Type: Bug
> Reporter: Owen O'Malley
>
> We're currently getting:
> {code}
> [ 43%] Building CXX object c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o
> In file included from /home/travis/build/apache/orc/c++/src/io/InputStream.cc:20:
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:75:13: error: '~SeekableArrayInputStream' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
> virtual ~SeekableArrayInputStream();
> ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:53:13: note: overridden virtual function is here
> virtual ~SeekableInputStream();
> ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:104:13: error: '~SeekableFileInputStream' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
> virtual ~SeekableFileInputStream();
> ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:53:13: note: overridden virtual function is here
> virtual ~SeekableInputStream();
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)