You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/25 05:01:14 UTC
[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #2214: Add Spark Engine on Kubernetes integration test
ulysses-you opened a new pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Rename `kyuubi-deployment-kubernetes-it` to `kyuubi-kubernetes-it` which include:
- Kyuubi Server on Kubernetes it
- Kyuubi Spark Engine on Kubernetes it
Now, we use the package name to distingush the scope of it:
- deployment package is for Kyuubi Server
- spark package is for Spark Engine
So it's easy to add Flink Engine on kubernetes it in future.
Note that, this PR only supports Spark client mode on Kubernetes it.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#issuecomment-1078749756
CI is green
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834978230
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.kubernetes.test.spark
+
+import org.apache.kyuubi.{Logging, WithKyuubiServer}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.kubernetes.test.MiniKube
+import org.apache.kyuubi.operation.SparkQueryTests
+
+// TODO Support Spark Cluster mode
Review comment:
Actually I have not tried test in cluster mode, it requires a remote file system. which is quite different with client mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834993008
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.kubernetes.test.spark
+
+import org.apache.kyuubi.{Logging, WithKyuubiServer}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.kubernetes.test.MiniKube
+import org.apache.kyuubi.operation.SparkQueryTests
+
+// TODO Support Spark Cluster mode
Review comment:
Another thing to pay attention to, with cluster mode we need found somewhere to store `kyuubi-spark-engine jar`. Specify `spark.kubernetes.file.upload.path` or put it into docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834973396
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/deployment/KyuubiOnKubernetesTestsSuite.scala
##########
@@ -15,13 +15,23 @@
* limitations under the License.
*/
-package org.apache.kyuubi.kubernetes.test
+package org.apache.kyuubi.kubernetes.test.deployment
import org.apache.kyuubi.Logging
+import org.apache.kyuubi.kubernetes.test.MiniKube
import org.apache.kyuubi.operation.SparkQueryTests
-// TODO: [KYUUBI-863] Support test Spark engine using k8s master with minikube
-class KubernetesJDBCTestsSuite extends SparkQueryTests with Logging {
+/**
+ * This test is for Kyuubi Server on Kubernetes with Spark engine:
+ *
+ * Real World Kubernetes Pod (docker container)
Review comment:
I suggest to remove `(docker container)` in description, because a Pod compose of one or more containers, and K8s has dropped the support of DockerShim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834971747
##########
File path: .github/workflows/master.yml
##########
@@ -145,22 +145,22 @@ jobs:
- name: Setup Minikube
uses: manusa/actions-setup-minikube@v2.4.3
with:
- minikube version: 'v1.16.0'
- kubernetes version: 'v1.19.2'
+ minikube version: 'v1.25.2'
Review comment:
why downgrade the version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#issuecomment-1078669752
@zwangsheng @cfmcgrady @hddong @pan3793 @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834978501
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/deployment/KyuubiOnKubernetesTestsSuite.scala
##########
@@ -15,13 +15,23 @@
* limitations under the License.
*/
-package org.apache.kyuubi.kubernetes.test
+package org.apache.kyuubi.kubernetes.test.deployment
import org.apache.kyuubi.Logging
+import org.apache.kyuubi.kubernetes.test.MiniKube
import org.apache.kyuubi.operation.SparkQueryTests
-// TODO: [KYUUBI-863] Support test Spark engine using k8s master with minikube
-class KubernetesJDBCTestsSuite extends SparkQueryTests with Logging {
+/**
+ * This test is for Kyuubi Server on Kubernetes with Spark engine:
+ *
+ * Real World Kubernetes Pod (docker container)
Review comment:
yeah we can remove the word
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834973396
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/deployment/KyuubiOnKubernetesTestsSuite.scala
##########
@@ -15,13 +15,23 @@
* limitations under the License.
*/
-package org.apache.kyuubi.kubernetes.test
+package org.apache.kyuubi.kubernetes.test.deployment
import org.apache.kyuubi.Logging
+import org.apache.kyuubi.kubernetes.test.MiniKube
import org.apache.kyuubi.operation.SparkQueryTests
-// TODO: [KYUUBI-863] Support test Spark engine using k8s master with minikube
-class KubernetesJDBCTestsSuite extends SparkQueryTests with Logging {
+/**
+ * This test is for Kyuubi Server on Kubernetes with Spark engine:
+ *
+ * Real World Kubernetes Pod (docker container)
Review comment:
I suggest to remove `(docker container)` in description, because a Pod is compose of one or more containers, and K8s has dropped the support of DockerShim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#issuecomment-1078689018
+1, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834976975
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.kubernetes.test.spark
+
+import org.apache.kyuubi.{Logging, WithKyuubiServer}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.kubernetes.test.MiniKube
+import org.apache.kyuubi.operation.SparkQueryTests
+
+// TODO Support Spark Cluster mode
Review comment:
That's a tricky thing, got asked from user several times. The official Spark docker image has only one UID 185 w/o user name[1], Kyuubi will append `--proxy-user` to `spark-submit` command if `--keytab` absent, then cause `185 is not allowed to impersonate <user>`. Do you encounter other blockers for Cluster mode?
[1]https://spark.apache.org/docs/latest/running-on-kubernetes.html#user-identity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#issuecomment-1078736939
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2214](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6dda43) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8f2b7358e47bb5f01989d61bb4eb16a4af9b64ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f2b735) will **decrease** coverage by `0.01%`.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## master #2214 +/- ##
============================================
- Coverage 61.69% 61.67% -0.02%
Complexity 69 69
============================================
Files 332 332
Lines 15947 15951 +4
Branches 2027 2028 +1
============================================
Hits 9838 9838
- Misses 5289 5292 +3
- Partials 820 821 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `87.25% <80.00%> (-0.75%)` | :arrow_down: |
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `94.11% <0.00%> (-1.97%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/flink/FlinkSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9GbGlua1NRTEVuZ2luZS5zY2FsYQ==) | `22.22% <0.00%> (-0.64%)` | :arrow_down: |
| [...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvZmxpbmsvRmxpbmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `73.17% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f2b735...f6dda43](https://codecov.io/gh/apache/incubator-kyuubi/pull/2214?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on a change in pull request #2214: Add Spark Engine on Kubernetes integration test
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on a change in pull request #2214:
URL: https://github.com/apache/incubator-kyuubi/pull/2214#discussion_r834981895
##########
File path: integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.kubernetes.test.spark
+
+import org.apache.kyuubi.{Logging, WithKyuubiServer}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.kubernetes.test.MiniKube
+import org.apache.kyuubi.operation.SparkQueryTests
+
+// TODO Support Spark Cluster mode
Review comment:
Maybe we could do a post in the discussion and ask if everyone have any better ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org