You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2018/05/08 05:04:20 UTC

[GitHub] incubator-quickstep pull request #354: Fixed the union-all elimiation case w...

GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/354

    Fixed the union-all elimiation case where some project expression is not an AttributeReference.

    This PR fixed for the case where the only one child of the union-all query is non-empty, and the child has a non-AttributeReference project expression:
    
    ```
    SELECT 1 AS a FROM not_empty
    UNION ALL
    SELECT 0 AS a FROM empty;
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuyu/incubator-quickstep eliminate-empty-node-bug-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #354
    
----
commit f7d1132672f4ef6399dbbe77541f93911c2d640b
Author: Zuyu Zhang <zu...@...>
Date:   2018-05-08T04:58:35Z

    Fixed the union-all elimiation case where some project expression is not an AttributeReference.

----


---

[GitHub] incubator-quickstep issue #354: Fixed the union-all elimiation case where so...

Posted by jianqiao <gi...@git.apache.org>.

Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/354
  
    LGTM! Merging.


---

[GitHub] incubator-quickstep pull request #354: Fixed the union-all elimiation case w...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/354


---