You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Christophe Lombart (JIRA)" <ji...@apache.org> on 2009/06/02 22:41:07 UTC

[jira] Created: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Prototype for a Sling Explorer implementation based on GWT
----------------------------------------------------------

                 Key: SLING-990
                 URL: https://issues.apache.org/jira/browse/SLING-990
             Project: Sling
          Issue Type: New Feature
          Components: Extensions
            Reporter: Christophe Lombart


Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
Not sure but I think that LGPL is compatible with the Apache project. 

Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 


[1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
[2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715822#action_12715822 ] 

Felix Meschberger commented on SLING-990:
-----------------------------------------

I did not run the code, I just looked at the contents of the package. This lookes very interesting but misses a few things:

  * We need the LICENSE and NOTICE file (and the DISCLAIMER, but this we can add on SVN commit)
  * What is the licencse (and source) of the images and CSS files included ? These might have to be
        attributed in the NOTICE file and *not* be (L)GPL-ed. Also a LICENSE file would be required for
        them unless they are ASL licensed.


In tree-node.json.esp you do :

            if (childNode == null)
            {
                name += child.path;
            }
            else 
            {
                name += childNode.name;
                //name = child.path;
             }

To get the label of the resource. You might use ResourceUtil.getName(resource) here, which does the same and does not rely on the resource being a node.

children.json.esp seems to be JCR-based: How about using the Sling Resource abstractions here : listing children using ResourceResolver.listChildren and getting the propreties with Resource.adaptTo(ValueMap.class) ?

> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717703#action_12717703 ] 

Christophe Lombart commented on SLING-990:
------------------------------------------

Thanks for your comments. 

Yes, it  is just a prototype and it is read-only :-) 
I would like to get more comments before adding more features. 

What's the conclusion for SmartGwt ? I can make a try with SmartGwt folks to see if it is not possible to change their license. Or maybe you ? because you have more ASF/open source experience. Your arguments will be certainly better :-) 



> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715866#action_12715866 ] 

Christophe Lombart commented on SLING-990:
------------------------------------------

I will modify the JSON scripts. 

Ok for LICENSE, NOTICE & DISCLAIMER. I will add them if we can resolve the license issue. 

The resources (images, css & js)  are under LGPL. I took those files from Smart GWT 1.1 distribution. Maybe we can use others. 

If LGPL is an issue, we cannot continue to use SmartGwt because the current implementention  requires 2 SmartGWT jars (see the pom.xml). Those jars are also under LGPL. There are used to run the application in the hosted mode and compile de java code into js. 








> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717698#action_12717698 ] 

Bertrand Delacretaz commented on SLING-990:
-------------------------------------------

I had a quick look and this looks good.

To build it, I had to set the maven-sling-plugin <version> to 2.0.4-incubator in pom.xml

Also, I think the URL used to access the explorer ( /explorer/index.html ) is not mentioned in the README.

Is it correct that this version is read-only? That's not a problem, I'm just not sure if I haven't found how to edit stuff ;-)

> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Juan Jose Vazquez Delgado (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717724#action_12717724 ] 

Juan Jose Vazquez Delgado commented on SLING-990:
-------------------------------------------------

Congrats Christophe, looks good!.

Regarding SmartGwt, I´d prefer to keep more simple with just GWT :).

> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717683#action_12717683 ] 

Christophe Lombart commented on SLING-990:
------------------------------------------

SmartGwt provides more advanced widgets. That's the main reason why I started the explorer with it. 
We can use GWT  but it will take more time to provide a nice UI. 

SmartGWT is already based on a dual license (LGPL & commercial). 

I can refactor the project to use only  GWT 

 


> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715868#action_12715868 ] 

Felix Meschberger commented on SLING-990:
-----------------------------------------

> I will modify the JSON scripts. 

Cool, so we get a Resource tree explorer !

> The resources (images, css & js) are under LGPL. I took those files from Smart GWT 1.1 distribution. Maybe we can use others.

Could these be extracted from the artifact downloaded from the maven repository on build time ? So that we don't have to store this in our SVN.

> If LGPL is an issue, we cannot continue to use SmartGwt because the current implementention requires 2 SmartGWT jars
> (see the pom.xml). Those jars are also under LGPL. There are used to run the application in the hosted mode and compile
> de java code into js.

Would it be a big problem to not be able to use SmartGWT ?



> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Lombart updated SLING-990:
-------------------------------------

    Attachment: Sling Explorer.zip

Here is the code. The README file contains information on useful maven command & GWT setting. 

> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by Felix Meschberger <fm...@gmail.com>.
Hi all,

Felix Meschberger (JIRA) schrieb:
>> Not sure but I think that LGPL is compatible with the Apache project.
> 
> Unfortunately not. Apache projects are not allowed to distribute artifacts including artifacts licensed under any GPL or LGPL license.

I think, this primarily means we are not allowed to distribute the final
bundle build as a JAR file containing the (L)GPL licensed stuff.

IIRC we are allowed to have the source in the SVN repo provided it only
contains properly licensed files and we probably should make sure that
anyone using this is aware of using (L)GPL licensed when building and
running.

Maybe Jukka may add to this ?

Regards
Felix

> 
>> Prototype for a Sling Explorer implementation based on GWT
>> ----------------------------------------------------------
>>
>>                 Key: SLING-990
>>                 URL: https://issues.apache.org/jira/browse/SLING-990
>>             Project: Sling
>>          Issue Type: New Feature
>>          Components: Extensions
>>            Reporter: Christophe Lombart
>>         Attachments: Sling Explorer.zip
>>
>>
>> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
>> Not sure but I think that LGPL is compatible with the Apache project. 
>> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
>> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
>> [2] http://code.google.com/p/smartgwt/
> 

[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715811#action_12715811 ] 

Felix Meschberger commented on SLING-990:
-----------------------------------------

> Not sure but I think that LGPL is compatible with the Apache project.

Unfortunately not. Apache projects are not allowed to distribute artifacts including artifacts licensed under any GPL or LGPL license.

> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-990) Prototype for a Sling Explorer implementation based on GWT

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717680#action_12717680 ] 

Bertrand Delacretaz commented on SLING-990:
-------------------------------------------

> Would it be a big problem to not be able to use SmartGWT ? 

Or would you be able to convince the SmartGWT folks to change their license or to use a dual license?

> Prototype for a Sling Explorer implementation based on GWT
> ----------------------------------------------------------
>
>                 Key: SLING-990
>                 URL: https://issues.apache.org/jira/browse/SLING-990
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Lombart
>         Attachments: Sling Explorer.zip
>
>
> Following the Sling Explorer proposal [1], I have started an implementation with the  SwartGwt UI framework [2] (based on GWT and under LGPL licence). 
> Not sure but I think that LGPL is compatible with the Apache project. 
> Until now, it is just a prototype. Can you review the code and see if this Gwt application is well integrated with Sling ? 
> [1] http://cwiki.apache.org/SLING/sling-based-jcr-explorer.html
> [2] http://code.google.com/p/smartgwt/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.