Re: [PR] [SPARK-50705][SQL] Make `QueryPlan` lock-free [spark]

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1906471684


##########
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##########
@@ -463,6 +463,27 @@ abstract class SparkFunSuite
       condition = "TABLE_OR_VIEW_ALREADY_EXISTS",
       parameters = Map("relationName" -> tableName))
 
+  protected def roundtripSerialize[T](obj: T): T = {
+    deserializeFromBytes(serializeToBytes(obj))
+  }
+
+  protected def serializeToBytes[T](o: T): Array[Byte] = {

Review Comment:
   Do they need to be at the level of `SparkFunSuite`? Shall we just add a base test suite with these methods for the two new suites? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org