You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/20 01:33:45 UTC
[GitHub] [spark] wangyum commented on issue #26172:
[WIP][SPARK-29516][SQL][TEST] Test ThriftServerQueryTestSuite asynchronously
wangyum commented on issue #26172: [WIP][SPARK-29516][SQL][TEST] Test ThriftServerQueryTestSuite asynchronously
URL: https://github.com/apache/spark/pull/26172#issuecomment-544211685
It seems the reason it `SQLConf.get` usage in [`ParseDriver.scala#L91-L103`](https://github.com/apache/spark/blob/b917a6593dc969b9b766259eb8cbbd6e90e0dc53/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala#L91-L103). We can reproduce this issue after [this commit](https://github.com/apache/spark/pull/26172/commits/5c896ced3d44446fce8d185a58aab32aacbb978e):
```shell
build/sbt "hive-thriftserver/test-only *.ThriftServerQueryTestSuite -- -z postgreSQL" -Phive-thriftserver
```
The output is:
```
================================================================================================
statement: set spark.sql.ansi.enabled=false
spark.sql.ansi.enabled before: true
SQLConf.get.ansiEnabled: true
spark.sql.ansi.enabled after: false
================================================================================================
statement: select i, left('ahoj', i), right('ahoj', i) from range(-5, 6) t(i) order by i
spark.sql.ansi.enabled before: false
SQLConf.get.ansiEnabled: true
================================================================================================
statement: set spark.sql.ansi.enabled=true
spark.sql.ansi.enabled before: false
SQLConf.get.ansiEnabled: true
spark.sql.ansi.enabled after: true
[info] - postgreSQL/text.sql *** FAILED *** (1 second, 489 milliseconds)
[info] "-1
[info] -2
[info] -3
[info] -4
[info] -5
[info] 0
[info] 1 a j
[info] 2 ah oj
[info] 3 aho hoj
[info] 4 ahoj ahoj
[info] 5 ahoj ahoj" did not contain "Exception" Exception did not match for query #19
[info] select i, left('ahoj', i), right('ahoj', i) from range(-5, 6) t(i) order by i, expected: -1
[info] -2
[info] -3
[info] -4
[info] -5
[info] 0
[info] 1 a j
[info] 2 ah oj
[info] 3 aho hoj
[info] 4 ahoj ahoj
[info] 5 ahoj ahoj, but got: java.sql.SQLException
[info] Error running query: org.apache.spark.sql.catalyst.parser.ParseException:
[info] no viable alternative at input 'left'(line 1, pos 10)
[info]
[info] == SQL ==
[info] select i, left('ahoj', i), right('ahoj', i) from range(-5, 6) t(i) order by i
[info] ----------^^^ (ThriftServerQueryTestSuite.scala:225)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org