You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 18:35:01 UTC

[GitHub] [incubator-superset] tanmaylaud commented on pull request #11002: fix: revert #10455 to fix the Timer component

tanmaylaud commented on pull request #11002:
URL: https://github.com/apache/incubator-superset/pull/11002#issuecomment-696904190


   thanks @graceguo-supercat  for reverting. 
   Although it would be important to discuss and figure out what is exactly breaking the Timer logic.
   Use of functional components is recommended, so simply reverting to class components will not be useful in the long run.
   Let me know if we can open up a discussion for this? @JunlinC @etr2460 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org