You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Peter Vary <pv...@cloudera.com> on 2016/09/21 15:15:55 UTC
Review Request 52122: HIVE-9423 - HiveServer2: Implement some
admission
control mechanism for graceful degradation when resources are exhausted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/
-----------------------------------------------------------
Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav Gumashta, and Barna Zsombor Klara.
Bugs: HIVE-9423
https://issues.apache.org/jira/browse/HIVE-9423
Repository: hive-git
Description
-------
Adding different error message depending on the thrown TTransportException
Diffs
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6
beeline/src/main/resources/BeeLine.properties 13321d2
beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION
Diff: https://reviews.apache.org/r/52122/diff/
Testing
-------
Manual, and added unit test depending on the exception code
Thanks,
Peter Vary
Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some
admission
control mechanism for graceful degradation when resources are exhausted
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/#review149826
-----------------------------------------------------------
Ship it!
+1, just some typos.
Thanks for the patch.
beeline/src/main/resources/BeeLine.properties (line 148)
<https://reviews.apache.org/r/52122/#comment217553>
The root cause might be **a** too high concurrent number of connections. Please check the number of active connections and adjust hive.server2.thrift.max.worker.threads **if** applicable.
- Barna Zsombor Klara
On Sept. 21, 2016, 3:15 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52122/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 3:15 p.m.)
>
>
> Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav Gumashta, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-9423
> https://issues.apache.org/jira/browse/HIVE-9423
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding different error message depending on the thrown TTransportException
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6
> beeline/src/main/resources/BeeLine.properties 13321d2
> beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52122/diff/
>
>
> Testing
> -------
>
> Manual, and added unit test depending on the exception code
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some
admission
control mechanism for graceful degradation when resources are exhausted
Posted by Marta Kuczora <ku...@cloudera.com>.
> On Sept. 22, 2016, 3:21 p.m., Marta Kuczora wrote:
> > beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java, line 58
> > <https://reviews.apache.org/r/52122/diff/2/?file=1507972#file1507972line58>
> >
> > Wouldn't it be better to split these checks into different test cases, so that one test would contain only one check?
>
> Peter Vary wrote:
> I was thinking about it, and decided to use only one test, since this is testing one switch statement.
> Does it make sense?
Yes, it makes sense, i am fine with one test case.
- Marta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/#review150014
-----------------------------------------------------------
On Sept. 22, 2016, 8:12 a.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52122/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 8:12 a.m.)
>
>
> Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav Gumashta, Vihang Karajgaonkar, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-9423
> https://issues.apache.org/jira/browse/HIVE-9423
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding different error message depending on the thrown TTransportException
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6
> beeline/src/main/resources/BeeLine.properties 13321d2
> beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52122/diff/
>
>
> Testing
> -------
>
> Manual, and added unit test depending on the exception code
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some
admission
control mechanism for graceful degradation when resources are exhausted
Posted by Peter Vary <pv...@cloudera.com>.
> On Sept. 22, 2016, 3:21 p.m., Marta Kuczora wrote:
> > beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java, line 58
> > <https://reviews.apache.org/r/52122/diff/2/?file=1507972#file1507972line58>
> >
> > Wouldn't it be better to split these checks into different test cases, so that one test would contain only one check?
I was thinking about it, and decided to use only one test, since this is testing one switch statement.
Does it make sense?
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/#review150014
-----------------------------------------------------------
On Sept. 22, 2016, 8:12 a.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52122/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 8:12 a.m.)
>
>
> Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav Gumashta, Vihang Karajgaonkar, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-9423
> https://issues.apache.org/jira/browse/HIVE-9423
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding different error message depending on the thrown TTransportException
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6
> beeline/src/main/resources/BeeLine.properties 13321d2
> beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52122/diff/
>
>
> Testing
> -------
>
> Manual, and added unit test depending on the exception code
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some
admission
control mechanism for graceful degradation when resources are exhausted
Posted by Marta Kuczora <ku...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/#review150014
-----------------------------------------------------------
beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java (line 58)
<https://reviews.apache.org/r/52122/#comment217822>
Wouldn't it be better to split these checks into different test cases, so that one test would contain only one check?
Thanks for the patch! I have just one question, it is a minor thing.
Otherwise looks good to me.
- Marta Kuczora
On Sept. 22, 2016, 8:12 a.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52122/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 8:12 a.m.)
>
>
> Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav Gumashta, Vihang Karajgaonkar, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-9423
> https://issues.apache.org/jira/browse/HIVE-9423
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adding different error message depending on the thrown TTransportException
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6
> beeline/src/main/resources/BeeLine.properties 13321d2
> beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52122/diff/
>
>
> Testing
> -------
>
> Manual, and added unit test depending on the exception code
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some
admission
control mechanism for graceful degradation when resources are exhausted
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/
-----------------------------------------------------------
(Updated Sept. 22, 2016, 8:12 a.m.)
Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav Gumashta, Vihang Karajgaonkar, and Barna Zsombor Klara.
Changes
-------
Addressed Lefty's and Zsombor's comments
Bugs: HIVE-9423
https://issues.apache.org/jira/browse/HIVE-9423
Repository: hive-git
Description
-------
Adding different error message depending on the thrown TTransportException
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6
beeline/src/main/resources/BeeLine.properties 13321d2
beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION
Diff: https://reviews.apache.org/r/52122/diff/
Testing
-------
Manual, and added unit test depending on the exception code
Thanks,
Peter Vary