You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/14 22:22:00 UTC
[jira] [Updated] (ARROW-4578) [JS] Float16Vector toArray should be
zero-copy
[ https://issues.apache.org/jira/browse/ARROW-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated ARROW-4578:
----------------------------------
Labels: pull-request-available (was: )
> [JS] Float16Vector toArray should be zero-copy
> ----------------------------------------------
>
> Key: ARROW-4578
> URL: https://issues.apache.org/jira/browse/ARROW-4578
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: JS-0.4.0
> Reporter: Paul Taylor
> Assignee: Paul Taylor
> Priority: Major
> Labels: pull-request-available
> Fix For: JS-0.4.1
>
>
> The {{Float16Vector#toArray()}} implementation currently transforms each half float into a single float, and returns a Float32Array. All the other {{toArray()}} implementations are zero-copy, and this deviation would break anyone expecting to give two-byte half floats to native APIs like WebGL. We should instead include {{Float16Vector#toFloat32Array()}} and {{Float16Vector#toFloat64Array()}} convenience methods that do rely on copying.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)