Guava upgrade?

[Paul Hammant <pa...@hammant.org>]

Guava broke backwards compatibility again. Downstream uses (like
Cassandra-Java) have to do more than just bump a version of a dep, sadly.
Version 27.0 is out -
https://mvnrepository.com/artifact/com.google.guava/guava/27.0-jre

Can Cassandra upgrade Guava to latest, please?  Then downstream users of
Cassandra can upgrade too.

Perhaps also consider shading Guava if the usage is entirety a internal
concern.

I'd have raised a Jira ticket, but https://issues.apache.org/jira is pretty
much non-responsive for search and new issues.  I'd raise a ticket for that
too, but ...

- Paul

Re: Guava upgrade?

[Paul Hammant <pa...@hammant.org>]

Hi Andy.

I found https://github.com/datastax/java-driver-shaded-guava which shades
Guava. I made a PR for it to include v27 but the maintainer thinks there's
no difference in API from v26, which is worth confirming. I'll do more
investigation.

- Paul

Re: Guava upgrade?

[Andy Tolbert <an...@datastax.com>]

Hi Paul,

There is a ticket with some work done for upgrading to Guava 26 (
https://issues.apache.org/jira/browse/CASSANDRA-14655 ).  It looks like
there are no breaking changes between Guava 26 and 27, so it might just
work if that patch is accepted.

With regards to shading, I'm not sure if there is precedent for doing that
in the project since Cassandra is primarily used as a standalone
application and not an embedded dependency (although of course it can be
used in this way), but Guava would probably be a good place to start.  On
the other hand I think the Guava team is much more mindful about not making
breaking changes these days, so it may not be as needed as before once C*
gets to a newer version.

Thanks,
Andy

On Sun, Oct 28, 2018 at 6:29 AM Paul Hammant <pa...@hammant.org> wrote:

> Guava broke backwards compatibility again. Downstream uses (like
> Cassandra-Java) have to do more than just bump a version of a dep, sadly.
> Version 27.0 is out -
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__mvnrepository.com_artifact_com.google.guava_guava_27.0-2Djre&d=DwIBaQ&c=adz96Xi0w1RHqtPMowiL2g&r=VHsWqsWT2MoX5jRZ0xZfdAWZxBsrn5KzowynGYCJaXE&m=feubAeyD8Mwq9s6_2hi8fYtaR9QyS5aZoNOwDLgO1Bg&s=YiKLGKo49nJT2L4KauAXMGdH3ZowHF9A0SVakg2HiuA&e=
>
> Can Cassandra upgrade Guava to latest, please?  Then downstream users of
> Cassandra can upgrade too.
>
> Perhaps also consider shading Guava if the usage is entirety a internal
> concern.
>
> I'd have raised a Jira ticket, but
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira&d=DwIBaQ&c=adz96Xi0w1RHqtPMowiL2g&r=VHsWqsWT2MoX5jRZ0xZfdAWZxBsrn5KzowynGYCJaXE&m=feubAeyD8Mwq9s6_2hi8fYtaR9QyS5aZoNOwDLgO1Bg&s=zEzpvP3hxSBlz3yJ0BbSUF1MP9SzTtNsFUh--Wz56jM&e=
> is pretty
> much non-responsive for search and new issues.  I'd raise a ticket for that
> too, but ...
>
> - Paul
>