You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/20 13:26:01 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5474: change logging during upgrade

sureshanaparti commented on a change in pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#discussion_r712164487



##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
##########
@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
                                 conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
                             alter_iso_pstmt.executeUpdate();
                         }catch (SQLException e) {
-                            s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+                            s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());

Review comment:
       ```suggestion
                               s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:" + e.getMessage());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org