You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/22 08:51:54 UTC

[GitHub] [flink] zentol commented on a change in pull request #18866: [FLINK-26289][runtime] AdaptiveScheduler: Allow exception history to …

zentol commented on a change in pull request #18866:
URL: https://github.com/apache/flink/pull/18866#discussion_r811706540



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandler.java
##########
@@ -119,7 +119,9 @@ private static JobExceptionsInfoWithHistory createJobExceptionsInfo(
         final ArchivedExecutionGraph executionGraph =
                 executionGraphInfo.getArchivedExecutionGraph();
         if (executionGraph.getFailureInfo() == null) {
-            return new JobExceptionsInfoWithHistory();
+            return new JobExceptionsInfoWithHistory(

Review comment:
       Is this really something that should be solved in the REST API? This looks more like an issue with the ArchivedExecutionGraph that the scheduler returns.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandler.java
##########
@@ -119,7 +119,9 @@ private static JobExceptionsInfoWithHistory createJobExceptionsInfo(
         final ArchivedExecutionGraph executionGraph =
                 executionGraphInfo.getArchivedExecutionGraph();
         if (executionGraph.getFailureInfo() == null) {
-            return new JobExceptionsInfoWithHistory();
+            return new JobExceptionsInfoWithHistory(

Review comment:
       Is this really something that should be solved in the REST API? This looks more like an issue with the ArchivedExecutionGraph that the adaptive scheduler returns.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org