You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/21 22:18:21 UTC
[GitHub] vanzin commented on a change in pull request #23156:
[SPARK-24063][SS] Add maximum epoch queue threshold for ContinuousExecution
vanzin commented on a change in pull request #23156: [SPARK-24063][SS] Add maximum epoch queue threshold for ContinuousExecution
URL: https://github.com/apache/spark/pull/23156#discussion_r259139763
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/EpochCoordinatorSuite.scala
##########
@@ -43,14 +43,20 @@ class EpochCoordinatorSuite
private var writeSupport: StreamingWriteSupport = _
private var query: ContinuousExecution = _
private var orderVerifier: InOrder = _
+ private val epochBacklogQueueSize = 10
override def beforeEach(): Unit = {
val reader = mock[ContinuousReadSupport]
writeSupport = mock[StreamingWriteSupport]
query = mock[ContinuousExecution]
orderVerifier = inOrder(writeSupport, query)
- spark = new TestSparkSession()
+ spark = new TestSparkSession(
+ new SparkContext(
+ "local[2]", "test-sql-context",
+ new SparkConf().set("spark.sql.testkey", "true")
+ .set("spark.sql.streaming.continuous.epochBacklogQueueSize",
Review comment:
Use the constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org