You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/14 17:55:29 UTC

[GitHub] [helix] junkaixue commented on a change in pull request #1796: Add message util to create messages

junkaixue commented on a change in pull request #1796:
URL: https://github.com/apache/helix/pull/1796#discussion_r651157980



##########
File path: helix-core/src/main/java/org/apache/helix/model/Message.java
##########
@@ -82,6 +82,7 @@
     RESOURCE_TAG,
     FROM_STATE,
     TO_STATE,
+    TO_STATUS,

Review comment:
       Add a field could be make the message logic more complicated. You can let the from state as "NORMAL" to "FREEZE" or something.
   
   I think you are trying to make an extra field to differentiate whether it is freeze message or not. But I would suggest to use our message type to achieve that goal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org