You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/08/19 15:12:29 UTC

Review Request 37612: YARN ownership is not set correctly on container-executor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37612/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.


Bugs: AMBARI-12817
    https://issues.apache.org/jira/browse/AMBARI-12817


Repository: ambari


Description
-------

Permissions on the container-executor need to be set so the group used for the hadoop components but if YARN is installed after-the-fact (i.e. install cluster, then add service YARN) and you are using a non-default group (like "hadooptest") they are not being set.


> ls -la /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
---Sr-s--- 1 root hadoop 115062 Jul 14 09:07 /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor


Should be:

# ls -la /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
---Sr-s--- 1 root hadooptest 115062 Jul 14 09:07 /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackLevelConfigurationResourceDefinition.java ce6a5b3 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4afa9b0 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4b88aff 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 686e40c 
  ambari-server/src/main/resources/key_properties.json ff20b8b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 3fd010a 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml 049eeb2 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b478cc0 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e764739 
  ambari-web/app/controllers/wizard/step7_controller.js 4d13b5b 
  ambari-web/app/mixins/common/serverValidator.js b0c0772 

Diff: https://reviews.apache.org/r/37612/diff/


Testing
-------

In progress


Thanks,

Dmytro Sen


Re: Review Request 37612: YARN ownership is not set correctly on container-executor

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37612/#review95860
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Сер. 19, 2015, 5:18 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37612/
> -----------------------------------------------------------
> 
> (Updated Сер. 19, 2015, 5:18 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-12817
>     https://issues.apache.org/jira/browse/AMBARI-12817
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Permissions on the container-executor need to be set so the group used for the hadoop components but if YARN is installed after-the-fact (i.e. install cluster, then add service YARN) and you are using a non-default group (like "hadooptest") they are not being set.
> 
> 
> > ls -la /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
> ---Sr-s--- 1 root hadoop 115062 Jul 14 09:07 /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
> 
> 
> Should be:
> 
> # ls -la /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
> ---Sr-s--- 1 root hadooptest 115062 Jul 14 09:07 /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackLevelConfigurationResourceDefinition.java ce6a5b3 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4afa9b0 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4b88aff 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 686e40c 
>   ambari-server/src/main/resources/key_properties.json ff20b8b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 3fd010a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml 049eeb2 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b478cc0 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e764739 
>   ambari-web/app/controllers/wizard/step7_controller.js 4d13b5b 
>   ambari-web/app/mixins/common/serverValidator.js b0c0772 
> 
> Diff: https://reviews.apache.org/r/37612/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.746s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.037s]
> [INFO] Ambari Web ........................................ SUCCESS [31.815s]
> [INFO] Ambari Views ...................................... SUCCESS [2.124s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:38.019s]
> [INFO] ambari-metrics .................................... SUCCESS [0.305s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.265s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.025s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.818s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.002s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.222s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [4:12.366s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [1.357s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [2:40.344s]
> [INFO] Ambari Server ..................................... SUCCESS [1:18:30.469s]
> [INFO] Ambari Agent ...................................... SUCCESS [10.996s]
> [INFO] Ambari Client ..................................... SUCCESS [0.037s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.677s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [9.789s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.035s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.031s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [5.943s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 37612: YARN ownership is not set correctly on container-executor

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37612/
-----------------------------------------------------------

(Updated Авг. 19, 2015, 5:18 п.п.)


Review request for Ambari, Myroslav Papirkovskyy and Vitalyi Brodetskyi.


Bugs: AMBARI-12817
    https://issues.apache.org/jira/browse/AMBARI-12817


Repository: ambari


Description
-------

Permissions on the container-executor need to be set so the group used for the hadoop components but if YARN is installed after-the-fact (i.e. install cluster, then add service YARN) and you are using a non-default group (like "hadooptest") they are not being set.


> ls -la /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
---Sr-s--- 1 root hadoop 115062 Jul 14 09:07 /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor


Should be:

# ls -la /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor
---Sr-s--- 1 root hadooptest 115062 Jul 14 09:07 /usr/hdp/current/hadoop-yarn-nodemanager/bin/container-executor


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackLevelConfigurationResourceDefinition.java ce6a5b3 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4afa9b0 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4b88aff 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 686e40c 
  ambari-server/src/main/resources/key_properties.json ff20b8b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 3fd010a 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml 049eeb2 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py b478cc0 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e764739 
  ambari-web/app/controllers/wizard/step7_controller.js 4d13b5b 
  ambari-web/app/mixins/common/serverValidator.js b0c0772 

Diff: https://reviews.apache.org/r/37612/diff/


Testing (updated)
-------

[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.746s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.037s]
[INFO] Ambari Web ........................................ SUCCESS [31.815s]
[INFO] Ambari Views ...................................... SUCCESS [2.124s]
[INFO] Ambari Admin View ................................. SUCCESS [1:38.019s]
[INFO] ambari-metrics .................................... SUCCESS [0.305s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.265s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.025s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.818s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.002s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.222s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [4:12.366s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [1.357s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [2:40.344s]
[INFO] Ambari Server ..................................... SUCCESS [1:18:30.469s]
[INFO] Ambari Agent ...................................... SUCCESS [10.996s]
[INFO] Ambari Client ..................................... SUCCESS [0.037s]
[INFO] Ambari Python Client .............................. SUCCESS [0.677s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.789s]
[INFO] Ambari Shell ...................................... SUCCESS [0.035s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.031s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [5.943s]


Thanks,

Dmytro Sen