You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/04/02 03:53:39 UTC
[kudu-CR] client: remove a warning
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12909
Change subject: client: remove a warning
......................................................................
client: remove a warning
../../src/kudu/client/schema.cc:624:27: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
std::move(comment ? boost::optional<string>(*comment) : boost::none));
^
../../src/kudu/client/schema.cc:624:27: note: remove std::move call here
std::move(comment ? boost::optional<string>(*comment) : boost::none));
^~~~~~~~~~ ~
1 warning generated.
Change-Id: I15b60c8a4b245fa694a1abc5c60bced66ed3039b
---
M src/kudu/client/schema.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/12909/1
--
To view, visit http://gerrit.cloudera.org:8080/12909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15b60c8a4b245fa694a1abc5c60bced66ed3039b
Gerrit-Change-Number: 12909
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] client: remove a warning
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12909 )
Change subject: client: remove a warning
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b60c8a4b245fa694a1abc5c60bced66ed3039b
Gerrit-Change-Number: 12909
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Apr 2019 04:06:47 +0000
Gerrit-HasComments: No
[kudu-CR] client: remove a warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12909 )
Change subject: client: remove a warning
......................................................................
client: remove a warning
../../src/kudu/client/schema.cc:624:27: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
std::move(comment ? boost::optional<string>(*comment) : boost::none));
^
../../src/kudu/client/schema.cc:624:27: note: remove std::move call here
std::move(comment ? boost::optional<string>(*comment) : boost::none));
^~~~~~~~~~ ~
1 warning generated.
Change-Id: I15b60c8a4b245fa694a1abc5c60bced66ed3039b
Reviewed-on: http://gerrit.cloudera.org:8080/12909
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/schema.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15b60c8a4b245fa694a1abc5c60bced66ed3039b
Gerrit-Change-Number: 12909
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)