[GitHub] [yunikorn-core] yzhangal commented on a diff in pull request #507: [YUNIKORN-1385] To provide visibility to application's aggregated resource consumption

["yzhangal (via GitHub)" <gi...@apache.org>]

yzhangal commented on code in PR #507:
URL: https://github.com/apache/yunikorn-core/pull/507#discussion_r1117809604


##########
pkg/common/resources/resources.go:
##########
@@ -44,6 +46,55 @@ func (q Quantity) string() string {
 	return strconv.FormatInt(int64(q), 10)
 }
 
+// Util struct to keep track of application resource usage
+type UsedResourceTracker struct {
+	// Two level map for aggregated resource usage
+	// With instance type being the top level key, the mapped value is a map:
+	//   resource type (CPU, memory etc) -> the aggregated used time (in seconds) of the resource type
+	//
+	UsedResourceMap map[string]map[string]int64

Review Comment:
   Thanks for the review Qi, very good feedback, will be addressed in new rev.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org