You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/04/16 20:38:32 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2623: ARTEMIS-2309 TempQueueCleanerUpper instances are leaking

clebertsuconic commented on a change in pull request #2623: ARTEMIS-2309 TempQueueCleanerUpper instances are leaking
URL: https://github.com/apache/activemq-artemis/pull/2623#discussion_r275982029
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
 ##########
 @@ -153,7 +153,7 @@
 
    protected volatile boolean started = false;
 
-   protected final Map<SimpleString, TempQueueCleanerUpper> tempQueueCleannerUppers = new HashMap<>();
+   protected static final Map<SimpleString, TempQueueCleanerUpper> tempQueueCleannerUppers = new HashMap<>();
 
 Review comment:
   this does not work well here. 
   
   A HashMap on ServerSession is fine, as it represents a single thread context of the client.
   
   however, if you make it static. .that's an issue.
   
   
   Still, i am not sure i would make it static here, perhaps store such thing on the Server or other controller?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services