You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2008/08/19 09:10:49 UTC

Re: svn commit: r32535 - trunk/subversion/libsvn_subr

gstein@tigris.org wrote on Tue, 19 Aug 2008 at 01:12 -0700:
> Author: gstein
> Date: Tue Aug 19 01:12:41 2008
> New Revision: 32535
> 
> Log:
> Simplify computation digest length.
> 
> * subversion/libsvn_util
>   (libsvn_uril): add more failure detection checks.

No such file 'subversion/libsvn_util', no such symbol 'libsvn_uril', and I 
don't see any more checks added.

Wrong log message?

> 
> Modified:
>    trunk/subversion/libsvn_subr/checksum.c
> 
> Modified: trunk/subversion/libsvn_subr/checksum.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/checksum.c?pathrev=32535&r1=32534&r2=32535
> ==============================================================================
> --- trunk/subversion/libsvn_subr/checksum.c	Mon Aug 18 23:51:19 2008	(r32534)
> +++ trunk/subversion/libsvn_subr/checksum.c	Tue Aug 19 01:12:41 2008	(r32535)
> @@ -138,7 +138,7 @@ svn_checksum_parse_hex(svn_checksum_t **
>    SVN_ERR(validate_kind(kind));
>  
>    *checksum = svn_checksum_create(kind, pool);
> -  len = DIGESTSIZE((*checksum)->kind);
> +  len = DIGESTSIZE(kind);
>  
>    for (i = 0; i < len; i++)
>      {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r32535 - trunk/subversion/libsvn_subr

Posted by Greg Stein <gs...@gmail.com>.
Woah. Yeah... drastically wrong log msg. Hrm... :-(

(fixing...)

On Tue, Aug 19, 2008 at 2:10 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> gstein@tigris.org wrote on Tue, 19 Aug 2008 at 01:12 -0700:
>> Author: gstein
>> Date: Tue Aug 19 01:12:41 2008
>> New Revision: 32535
>>
>> Log:
>> Simplify computation digest length.
>>
>> * subversion/libsvn_util
>>   (libsvn_uril): add more failure detection checks.
>
> No such file 'subversion/libsvn_util', no such symbol 'libsvn_uril', and I
> don't see any more checks added.
>
> Wrong log message?
>
>>
>> Modified:
>>    trunk/subversion/libsvn_subr/checksum.c
>>
>> Modified: trunk/subversion/libsvn_subr/checksum.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/checksum.c?pathrev=32535&r1=32534&r2=32535
>> ==============================================================================
>> --- trunk/subversion/libsvn_subr/checksum.c   Mon Aug 18 23:51:19 2008        (r32534)
>> +++ trunk/subversion/libsvn_subr/checksum.c   Tue Aug 19 01:12:41 2008        (r32535)
>> @@ -138,7 +138,7 @@ svn_checksum_parse_hex(svn_checksum_t **
>>    SVN_ERR(validate_kind(kind));
>>
>>    *checksum = svn_checksum_create(kind, pool);
>> -  len = DIGESTSIZE((*checksum)->kind);
>> +  len = DIGESTSIZE(kind);
>>
>>    for (i = 0; i < len; i++)
>>      {
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org