You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/03 15:53:07 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

asdf2014 opened a new pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This PR bumps druid from 0.22.0 to 0.22.1, which is the latest version of Apache Druid.
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] dailidong commented on pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194#issuecomment-1030654204


   > Hi @dailidong, thanks for your comment. Yes, it's normal. Maybe we should add some Integration Test in follow-up PRs to ensure everything is working well. What do you think
   
   good suggestion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194#issuecomment-1031048745


   > +1 LGTM
   Hi, I'm not in favor of merging this PR, (at least not for now), have you paid attention to the relevant context?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194#issuecomment-1030653770


   Hi @dailidong, thanks for your comment. Yes, it's normal. Maybe we should add some Integration Test in follow-up PRs to ensure everything is working well. What do you think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] dailidong merged pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] dailidong commented on pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194#issuecomment-1030606339


   I noticed that this PR also update the log4j2 version from 2.8.2 to 2.15.0 and the netty version from 4.1.63 to 4.1.68


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] dailidong commented on pull request #1194: [SeaTunnel][Dependency] Bump druid from 0.22.0 to 0.22.1

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #1194:
URL: https://github.com/apache/incubator-seatunnel/pull/1194#issuecomment-1030607157


   I want to know whether SeaTunnel can run normally in your local environment when you did these changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org