You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2015/08/24 15:18:27 UTC
Review Request 37713: Tabs on the right disappear after executing
queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37713/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-12848
https://issues.apache.org/jira/browse/AMBARI-12848
Repository: ambari
Description
-------
The tabs attached to the right side of query editor disappears once a query is executed. However the tabs can be accessed by horizontal scrolling as seen in the screen-shots.
It is also found out that this issue can only be reproduced with the latest version of Google chrome(v44) and any version of Firefox. Google chrome v43 and below works fine.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 6507d6b
Diff: https://reviews.apache.org/r/37713/diff/
Testing
-------
manually tested on local VM. Ran ember test to check of any breaking tests.
Thanks,
Pallav Kulshreshtha
Re: Review Request 37713: Tabs on the right disappear after executing
queries
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37713/#review96209
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Aug. 24, 2015, 3:48 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37713/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 3:48 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-12848
> https://issues.apache.org/jira/browse/AMBARI-12848
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Applied the max-width to the query result container. Hence, it it will not cross the width limit and no scroll will appear.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 6507d6b
>
> Diff: https://reviews.apache.org/r/37713/diff/
>
>
> Testing
> -------
>
> manually tested on local VM. Ran ember test to check of any breaking tests.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 37713: Tabs on the right disappear after executing
queries
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37713/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 3:48 p.m.)
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-12848
https://issues.apache.org/jira/browse/AMBARI-12848
Repository: ambari
Description (updated)
-------
Applied the max-width to the query result container. Hence, it it will not cross the width limit and no scroll will appear.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 6507d6b
Diff: https://reviews.apache.org/r/37713/diff/
Testing
-------
manually tested on local VM. Ran ember test to check of any breaking tests.
Thanks,
Pallav Kulshreshtha